Nova 4 Support #16
Open
Nova 4 Support #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Contributor
|
Hi @stefblokdijk |
Author
|
I've updated the screenshots and tested the FormField. Feel free to review now |
|
Hey is there any chance this will be released soon please? |
|
Hulloooo? Need these updates please |
|
Specifically for Nova 4, you can also use this fork: khalin/nova4-indicator-field, for those interested in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nova 4 uses Vue 3, the Indicators weren't rendering on the latest Nova version.
This PR updates the package to support Nova 4 (just for the project i'm using it on) and likely won't be compatible with previous Nova versions. That is why i'd suggest to release this eventually as a v2 of this package with instructions how Nova 1 - 3 users should install v1 on their project.
Besides the Nova 4 / Vue 3 update, i've also made minor changes to the code styling to match other packages i've came across and a small CSS change to improve spacing between the indicator and the text. Feel free to revert these smaller changes if they don't match your workflow.
This PR is not 100% release ready since i've not