-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Labels
refactoring 🛠️Code refactoring and enhancementsCode refactoring and enhancements
Description
Why
Following the issue #2640 where we have implemented the first phase of the common aggregator client, we want to implement the second phase which consists in using the common aggregator client in the client library.
What
Use the new common aggregator client in the client library and remove the previous implementation of the aggregator client.
How
- Implement all the HTTP clients in the Mithril client library with requests in the new common aggregator client
- Remove the
AggregatorClienttrait and replace it withAggregatorRequesttraits (one for each sub-client) - Create a trait
AggregatorClientthat can be injected in the client builder to replace the implementation of the communication with an aggregator (Do we do that now?) - Remove the deprecated
with_aggregator_clientfunction in the Mithril client library - Publish manually the first version of the common aggregator client crate on crates.io + setup crate owner (@jpraynaud)
Metadata
Metadata
Assignees
Labels
refactoring 🛠️Code refactoring and enhancementsCode refactoring and enhancements