feat(perms): Builder permissioning Tower layer
#46
Conversation
src/perms/middleware.rs
Outdated
| StatusCode::BAD_REQUEST, | ||
| Json(ApiError { | ||
| error: "INVALID_HEADER_ENCODING", | ||
| message: "Invalid header encoding", |
There was a problem hiding this comment.
Some Hint: text in the human-readable strings would be great, re: expectations., what header is missing/invalid, and what does a valid one look like?
for next one,
why was permission denied?
There was a problem hiding this comment.
these are user facing API errors. I thought we wanted to be opaque here?
There was a problem hiding this comment.
we dont want to leak server internals by returning unmodified error objects that may contain things like stack traces. we do want to make them usefuk and helpful
src/perms/middleware.rs
Outdated
| return Ok(ApiError::permission_denied().into_response()); | ||
| } | ||
|
|
||
| info!(%sub, current_slot = %this.builders.calc().current_slot(), "builder permissioned successfully"); |
src/perms/middleware.rs
Outdated
| } | ||
| }, | ||
| None => { | ||
| error!("builder request missing header"); |
There was a problem hiding this comment.
this is probably not error, as it is not a problem with our system
src/perms/middleware.rs
Outdated
| } | ||
| Err(_) => { | ||
| return Ok((StatusCode::BAD_REQUEST, "invalid header").into_response()); | ||
| error!("builder request has invalid header encoding"); |
There was a problem hiding this comment.
this is probably not error, as it is not a problem with our system
Evalir
force-pushed
the
evalir/permissioning-tower-layer
branch
from
2b9d2d9 to
91c4c4e
Compare
Evalir
force-pushed
the
evalir/permissioning-tower-layer
branch
from
0f671dc to
0dcec62
Compare
Closes ENG-1165