Skip to content

WIP: Convert app state to MobX-State-Tree #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

WIP: Convert app state to MobX-State-Tree #1380

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2f922ae
feat: Zoom font size with cmd+ and cmd-
trevor-coleman Dec 15, 2023
4cd6cc0
Upgrade babel
jamonholmgren Dec 17, 2023
cda85f4
Adds patch for babel-plugin-minify-mangle-names
jamonholmgren Dec 17, 2023
b2ad6f7
Add mobx
jamonholmgren Dec 17, 2023
168abb1
Wasn't that, put it back
jamonholmgren Dec 17, 2023
411467b
Bring over mst changes
jamonholmgren Dec 17, 2023
7022e83
Adding diagnostics to figure out that React is not getting loaded the…
jamonholmgren Dec 17, 2023
6484cec
Merge branch 'master' into app/add-mst
jamonholmgren Dec 17, 2023
7abce20
Added mobx-react-lite to root as a workaround
jamonholmgren Dec 18, 2023
45e1c64
Moves mobx-react-lite back into the electron app dependencies.
markrickert Dec 19, 2023
52648d1
Delete and recreate yarn.lock
markrickert Dec 19, 2023
2028eae
Upgrade to the latest version of nx
markrickert Dec 19, 2023
3610777
Put mobx and mobx-state-tree into the whitelisted modules
markrickert Dec 19, 2023
5b8d701
Fix linting issues
jamonholmgren Dec 19, 2023
b539cfd
wip
jamonholmgren Dec 19, 2023
c676465
Fix whitespace
jamonholmgren Dec 19, 2023
3314f9f
Merge branch '1355-zoom-font-size' into app/add-mst
jamonholmgren Dec 19, 2023
cc32088
Add toggle sidebar functionality to menu
jamonholmgren Dec 19, 2023
fd07e19
MST: Update server status handling
jamonholmgren Dec 19, 2023
670158b
add withSetPropAction
jamonholmgren Dec 19, 2023
f4da210
Update import paths and types
jamonholmgren Dec 19, 2023
73825c1
Ported standalone to MST; broken state currently
jamonholmgren Dec 19, 2023
400ff5e
fix: platformVersion data type for Android
coolsoftwaretyler Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/reactotron-app/src/renderer/models/Connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const ConnectionModel = t

platform: t.enumeration(["ios", "android", "browser"] as const),
name: "",
platformVersion: "",
platformVersion: t.optional(t.union(t.number, t.string), ""),
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamonholmgren - platformVersion is coming back as a number on Android, and a string on iOS. This handles both and defaults to an empty string.

osRelease: "",
userAgent: "",

Expand Down
Loading