Skip to content

Commit 947bbcb

Browse files
committed
create README.md
1 parent 8e12c18 commit 947bbcb

File tree

6 files changed

+80
-5
lines changed

6 files changed

+80
-5
lines changed

README.md

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
# check_mk Plugin for Proxmox Backup Server
2+
[![release](https://github.com/inettgmbh/checkmk-proxmox_backup_server/actions/workflows/release.yml/badge.svg)](https://github.com/inettgmbh/checkmk-proxmox_backup_server/actions/workflows/release.yml)
3+
4+
This check_mk extension adds checks Proxmox Backup Server:
5+
* Datastore (Size, Usage)
6+
* Garbage collection
7+
* Verify jobs
8+
9+
## Warning
10+
This extension is still work in progress and **produces a huge agent output**
11+
12+
## Installation
13+
The mkp archive can be downloaded directly from the [release](https://github.com/inettgmbh/checkmk-proxmox_backup_server/releases/latest) and installed by following the [documentation of check_mk](https://docs.checkmk.com/latest/en/mkps.html).
14+
15+
## Building
16+
Usually you don't see a section as how to build an mkp, because usually it's done like check_mk suggests using [WATO](https://docs.checkmk.com/latest/en/mkps.html#_creating_packages) or [CLI](https://docs.checkmk.com/latest/en/mkps.html#_creating_a_package).
17+
But we made it easier and included two helper tools into this repository, that depend on the tool [python-mkp](https://github.com/inettgmbh/python-mkp), which is a fork of [tom-mi/python-mkp](https://github.com/tom-mi/python-mkp).
18+
Unfortunally, the original tool, which can be installed using `pip` **cannot** be used because it wouldn't package some files.
19+
20+
### Requirements
21+
* python-mkp
22+
23+
just run
24+
25+
```sh
26+
$ build/mkp-pack
27+
```
28+
29+
## Contributing
30+
31+
### issues, you can't fix / ideas, you can't implement
32+
33+
Use GitHub's [Issues](https://github.com/inettgmbh/checkmk-proxmox_backup_server/issues):
34+
Try to explain as clear and short as possible.
35+
36+
### you want to write some code?
37+
38+
* Use Pull requests
39+
* Sign off your commits
40+
* Adapt to the coding style. Divert from it, if doing so increases readability.
41+
* Don't check in IDE specific files or products of a build.
42+
43+
## Issues
44+
yes, we have those
45+
This extension 'works for us' right now, but it's far from optimal.
46+
47+
* Agent output is way to much and must be optimized
48+
* Names of metrics should be changed
49+
50+
## TODOs
51+
(even more, than issues)
52+
53+
* Check of sync jobs
54+
* Check prune jobs
55+
* Check tape jobs
56+
* Check, if verify jobs are running
57+
* Optimize parsing of agent output
58+
* Add check parameters for timeouts of verify, garbage collection and prune jobs
59+
* Move todos and issues to GitHub issues and projects (without being recursive)
60+

agent_based/proxmox_bs.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
#!/usr/bin/env python3
22
# -*- coding: utf-8 -*-
33

4+
# Copyright (c) 2021 inett GmbH
5+
# License: GNU General Public License v2
6+
# A file is subject to the terms and conditions defined in the file LICENSE,
7+
# which is part of this source code package.
8+
49
from .agent_based_api.v1 import (
510
get_value_store,
611
register,

agents/plugins/proxmox_bs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
#!/bin/bash
22

3+
# Copyright (c) 2021 inett GmbH
4+
# License: GNU General Public License v2
5+
# A file is subject to the terms and conditions defined in the file LICENSE,
6+
# which is part of this source code package.
7+
38
inpath() {
49
command -v "${1:?No command to test}" >/dev/null 2>&1
510
}

info

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
{'author': 'Maximilian Hill <mhill@inett.de>',
2-
'description': 'https://github.com/inettgmbh/checkmk-proxmox_backup_server',
3-
'download_url': 'https://github.com/inettgmbh/checkmk-proxmox_backup_server/releases',
2+
'description': 'https://www.inett.de/it-loesungen/checkmk',
3+
'download_url': 'https://github.com/inettgmbh/checkmk-proxmox_backup_server/releases/latest',
44
'files': {'agent_based': ['proxmox_bs.py'],
55
'agents': ['plugins/proxmox_bs'],
66
'lib': ['check_mk/base/cee/plugins/bakery/proxmox_bs.py'],
77
'web': ['plugins/wato/proxmox_bs.py']},
88
'name': 'proxmox_bs',
99
'num_files': 4,
1010
'title': 'Proxmox Backup Server',
11-
'version': '0.3.4',
11+
'version': '0.3.5',
1212
'version.min_required': '2.0.0',
1313
'version.packaged': '2.0.0p3',
1414
'version.usable_until': None}

lib/check_mk/base/cee/plugins/bakery/proxmox_bs.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
#!/usr/bin/env python3
22
# -*- encoding: utf-8; py-indent-offset: 4 -*-
3+
4+
# Copyright (c) 2021 inett GmbH
5+
# License: GNU General Public License v2
6+
# A file is subject to the terms and conditions defined in the file LICENSE,
7+
# which is part of this source code package.
8+
39
import pprint
410
from pathlib import Path
511
from typing import Any, Dict

web/plugins/wato/proxmox_bs.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
# -*- encoding: utf-8; py-indent-offset: 4 -*-
33

44
# Copyright (c) 2021 inett GmbH
5-
# Maximilian Hill <mhill@inett.de>
65
# License: GNU General Public License v2
7-
# A file is subject to the terms and conditions defined in the file COPYING,
6+
# A file is subject to the terms and conditions defined in the file LICENSE,
87
# which is part of this source code package.
98

109
from cmk.gui.i18n import _

0 commit comments

Comments
 (0)