Skip to content

Feature: types.Int - initial support for signed #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature: types.Int - initial support for signed #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bitcode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ export class Builder {
return new types.Void();
}

public static i(width: number): types.Int {
return new types.Int(width);
public static i(width: number, signed: boolean = false): types.Int {
return new types.Int(width, signed);
}

public static signature(returnType: Type, params: Type[]): types.Signature {
Expand Down
4 changes: 2 additions & 2 deletions src/types/int.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as values from '../values';
import { Type } from './base';

export class Int extends Type {
constructor(public readonly width: number) {
constructor(public readonly width: number, public readonly signed: boolean = false) {
super('i' + width);
}

Expand All @@ -16,7 +16,7 @@ export class Int extends Type {
}

const toInt = to as Int;
return toInt.width === this.width;
return toInt.width === this.width && toInt.signed === this.signed;
}

public val(num: number): values.constants.Int {
Expand Down