-
-
Notifications
You must be signed in to change notification settings - Fork 179
Open
Description
Hi all,
I think I stumbled across a minor bug:
The StackExchange.Redis.Extensions.Core.Configuration.RedisConfiguration's SyncTimeout is 1000ms by default.
However, it should be 5000ms acording to its documentation (and the StackExchange.Redis docs):
/// <summary>
/// Gets or sets the time in milliseconds that the system should allow for synchronous operations (defaults to 5 seconds).
/// </summary>
public int SyncTimeout
{
get => syncTimeout;
set
{
syncTimeout = value;
ResetConfigurationOptions();
}
}
I think the issue is the private int syncTimeout = 1000; initialization in the RedisConfiguration.cs:
Line 28 in 4aa17d1
| private int syncTimeout = 1000; |
Is it OK if I submit a PR for this quick fix?
Anyways, thanks a lot for your great work!
Metadata
Metadata
Assignees
Labels
No labels