fixed NAF reward discount #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jackokaiser wants to merge 1 commit into ikostrikov:master from jackokaiser:master

jackokaiser commented Aug 7, 2018

Hi Ilya,

Thanks for your open-source implementation of DDPG/NAF in pytorch.

We spotted a typo in NAF: the discount factor (and the done mask) should multiply the next_state_values instead of adding up to it.

Cheers,
Jacques


          fixed NAF reward discount

782e564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet