Including reviewer's comments.

Author: staudtMarius

src/main/java/edu/ie3/datamodel/io/naming/timeseries/LoadProfileMetaInformation.java

@@ -32,7 +32,7 @@ public boolean equals(Object o) {
 
   @Override
   public int hashCode() {
-    return Objects.hash(profile);
+    return Objects.hash(super.hashCode(), profile);
   }
 
   @Override

src/main/java/edu/ie3/datamodel/io/source/PowerValueSource.java

@@ -17,29 +17,21 @@
 
 /** Interface defining base functionality for power value sources. */
 public sealed interface PowerValueSource<
-        P extends PowerProfile, ID extends PowerValueSource.InputData>
+        P extends PowerProfile, I extends PowerValueSource.PowerValueIdentifier>
     permits PowerValueSource.MarkovBased, PowerValueSource.TimeSeriesBased {
 
   /** Returns the profile of this source. */
   P getProfile();
 
-  /**
-   * Method to get the next power value based on the provided input data.
-   *
-   * @param data input data that is used to calculate the next power value.
-   * @return an option for the power value.
-   */
-  Optional<PValue> getValue(ID data);
-
   /**
    * Method to get a supplier for the next power value based on the provided input data. Depending
    * on the implementation the supplier will either always return the same value or each time a
-   * random value. To return one constant value please use {@link #getValue(InputData)}.
+   * random value.
    *
    * @param data input data that is used to calculate the next power value.
    * @return A supplier for an option on the value at the given time step.
    */
-  Supplier<Optional<PValue>> getValueSupplier(ID data);
+  Supplier<Optional<PValue>> getValueSupplier(I data);
 
   /**
    * Method to determine the next timestamp for which data is present.
@@ -63,16 +55,16 @@ non-sealed interface TimeSeriesBased
       extends PowerValueSource<LoadProfile, TimeSeriesInputValue> {}
 
   /** Interface for markov-chain-based power value sources. */
-  non-sealed interface MarkovBased extends PowerValueSource<PowerProfile, InputData> {}
+  non-sealed interface MarkovBased extends PowerValueSource<PowerProfile, PowerValueIdentifier> {}
 
   // -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
   // input data
 
   /**
-   * Interface for the input data of {@link #getValue(InputData)}. The data is used to determine the
-   * next power.
+   * Interface for the input data of {@link #getValueSupplier(PowerValueIdentifier)}. The data is
+   * used to determine the next power.
    */
-  sealed interface InputData permits PowerValueSource.TimeSeriesInputValue {
+  sealed interface PowerValueIdentifier permits PowerValueSource.TimeSeriesInputValue {
     /** Returns the timestamp for which a power value is needed. */
     ZonedDateTime getTime();
   }
@@ -82,7 +74,7 @@ sealed interface InputData permits PowerValueSource.TimeSeriesInputValue {
    *
    * @param time
    */
-  record TimeSeriesInputValue(ZonedDateTime time) implements InputData {
+  record TimeSeriesInputValue(ZonedDateTime time) implements PowerValueIdentifier {
     @Override
     public ZonedDateTime getTime() {
       return time;

src/main/java/edu/ie3/datamodel/io/source/csv/CsvLoadProfileSource.java

@@ -70,21 +70,11 @@ public Set<LoadProfileEntry<V>> getEntries() {
     return loadProfileTimeSeries.getEntries();
   }
 
-  @Override
-  public Optional<PValue> getValue(TimeSeriesInputValue data) {
-    return loadProfileTimeSeries.getValue(data.time());
-  }
-
   @Override
   public Supplier<Optional<PValue>> getValueSupplier(TimeSeriesInputValue data) {
     return loadProfileTimeSeries.supplyValue(data.time());
   }
 
-  @Override
-  public P getProfile() {
-    return loadProfileTimeSeries.getLoadProfile();
-  }
-
   @Override
   public Optional<ComparableQuantity<Power>> getMaxPower() {
     return loadProfileTimeSeries.maxPower();

src/main/java/edu/ie3/datamodel/io/source/sql/SqlLoadProfileSource.java

@@ -99,23 +99,11 @@ public Set<LoadProfileEntry<V>> getEntries() {
     return getEntries(queryFull, ps -> {});
   }
 
-  @Override
-  public Optional<PValue> getValue(TimeSeriesInputValue data) {
-    ZonedDateTime time = data.time();
-    return queryForValue(time).map(loadValue -> loadValue.getValue(time, profile));
-  }
-
   @Override
   public Supplier<Optional<PValue>> getValueSupplier(TimeSeriesInputValue data) {
     ZonedDateTime time = data.time();
     Optional<LoadValues<P>> loadValueOption = queryForValue(time);
-
-    if (loadValueOption.isPresent()) {
-      LoadValues<P> loadValue = loadValueOption.get();
-      return () -> Optional.of(loadValue.getValue(time, profile));
-    } else {
-      return Optional::empty;
-    }
+    return () -> loadValueOption.map(v -> v.getValue(time, profile));
   }
 
   @Override

src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlLoadProfileSourceIT.groovy

@@ -63,7 +63,8 @@ class SqlLoadProfileSourceIT extends Specification implements TestContainerHelpe
 
   def "A SqlTimeSeriesSource can read and correctly parse a single value for a specific date"() {
     when:
-    def value = loadSource.getValue(new PowerValueSource.TimeSeriesInputValue(TIME_00MIN))
+    def supplier = loadSource.getValueSupplier(new PowerValueSource.TimeSeriesInputValue(TIME_00MIN))
+    def value = supplier.get()
 
     then:
     value.present