Including reviewer's comments.

Author: staudtMarius

docs/readthedocs/_static/figures/transformerWithSwitchGear.png

@@ -159,9 +159,9 @@
 	    \begin{tikzpicture}
 	    % === Anschlüsse ===
 	        \node[circle, draw = tuGreen, fill = tuGreen, inner sep = 0, minimum height = 1.5mm] (port_a) at (0,0){};
-	        \node[circle, draw = tuOrange, fill = tuOrange, inner sep = 0, minimum height = 1.5mm] (port_b) at (15mm,0){};
-	        \node[circle, draw = tuOrange, fill = tuOrange, inner sep = 0, minimum height = 1.5mm] (port_c) at (30mm,0){};
-	        \node[circle, draw = tuOrange, fill = tuOrange, inner sep = 0, minimum height = 1.5mm] (port_d) at (45mm,0){};
+	        \node[circle, draw = tuOrange, fill = tuGreen, inner sep = 0, minimum height = 1.5mm] (port_b) at (15mm,0){};
+	        \node[circle, draw = tuOrange, fill = tuGreen, inner sep = 0, minimum height = 1.5mm] (port_c) at (30mm,0){};
+	        \node[circle, draw = tuOrange, fill = tuGreen, inner sep = 0, minimum height = 1.5mm] (port_d) at (45mm,0){};
 	        \node[circle, draw = tuOrange, fill = tuOrange, inner sep = 0, minimum height = 1.5mm] (port_e) at (62.5mm,0){};
 
 	        \draw (port_a.west) -- ++(-3mm, -1mm) -- ++(0mm, -2mm) edge[densely dotted] ++(0mm, -1.8mm);
@@ -176,9 +176,9 @@
 	        \draw (port_d.east) -- (winding_a.west) (winding_b.east) -- (port_e.west);
 
 	        \node[tuGreen, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_a.south) {A \\ \SI{110}{\kV} \\ 1};
-	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_b.south) {B \\ \SI{110}{\kV} \\ 2};
-	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_c.south) {C \\ \SI{110}{\kV} \\ 2};
-	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_d.south) {D \\ \SI{110}{\kV} \\ 2};
+	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_b.south) {B \\ \SI{110}{\kV} \\ 1};
+	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_c.south) {C \\ \SI{110}{\kV} \\ 1};
+	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_d.south) {D \\ \SI{110}{\kV} \\ 1};
 	        \node[tuOrange, anchor = north, inner sep = 2mm, text width = 10mm, align = center] at (port_e.south) {E \\ \SI{10}{\kV} \\ 2};
 	    \end{tikzpicture}
 \end{document}

docs/readthedocs/_static/figures/transformerWithSwitchGear.tex

@@ -20,6 +20,17 @@ Why predominant?
 As of convention, the `SubGridContainers` hold also reference to the transformers leading to higher sub grids
 and their higher voltage coupling point.
 
+![Sub grid boundary definition for transformers with upstream switchgear](../../../_static/figures/transformerWithSwitchGear.png)
+
+Let's shed a more detailed light on the boundaries of a sub grid as of our definition.
+This especially is important, if the switchgear of the transformer is modeled in detail.
+We defined, that all nodes in upstream direction of the transformer, including those, which are connected by switches *only*
+(therefore are within the switchgear) are counted towards the superior sub grid structure (here "1"), because they belong
+to a different voltage level.
+If a switchgear should be operated by the inferior grid, one can set the operator, that is used in the inferior grid, for
+the switchgear. This can be necessary, if we assume, that the interest to operate on the given switchgear will most likely
+be placed in the inferior grid structure.
+
 A synoptic overview of both classes' attributes is given here:
 
 ## Attributes, Units and Remarks

docs/readthedocs/models/input/grid/gridcontainer.md

@@ -585,66 +585,4 @@ class ContainerUtilsTest extends Specification {
     then:
     actual == expected
   }
-
-  def "Determining the surrounding sub grid containers of a two winding transformer w/ switchgear works fine"() {
-    given:
-    def nodeA = Mock(NodeInput)
-    nodeA.getUuid() >> UUID.fromString("a37b2501-70c5-479f-92f9-d5b0e4628b2b")
-    nodeA.getSubnet() >> 1
-    def nodeB = Mock(NodeInput)
-    nodeB.getUuid() >> UUID.fromString("8361b082-9d4c-4c54-97d0-2df9ac35333c")
-    nodeB.getSubnet() >> 1
-    def nodeC = Mock(NodeInput)
-    nodeC.getUuid() >> UUID.fromString("b9e4f16b-0317-4794-9f53-339db45a2092")
-    nodeC.getSubnet() >> 1
-    def nodeD = Mock(NodeInput)
-    nodeD.getUuid() >> UUID.fromString("ae4869d5-3551-4cce-a101-d61629716c4f")
-    nodeD.getSubnet() >> 1
-    def nodeE = Mock(NodeInput)
-    nodeE.getUuid() >> UUID.fromString("5d4107b2-385b-40fe-a668-19414bf45d9d")
-    nodeE.getSubnet() >> 2
-
-    def transformer = Mock(Transformer2WInput)
-    transformer.getUuid() >> UUID.fromString("ddcdd72a-5f97-4bef-913b-d32d31216e27")
-    transformer.getNodeA() >> nodeD
-    transformer.getNodeB() >> nodeE
-    transformer.allNodes() >> List.of(nodeD, nodeE)
-
-    def switchAB = Mock(SwitchInput)
-    switchAB.getUuid() >> UUID.fromString("5fcb8705-1436-4fbe-97b3-d2dcaf6a783b")
-    switchAB.allNodes() >> List.of(nodeA, nodeB)
-    def switchBC = Mock(SwitchInput)
-    switchBC.getUuid() >> UUID.fromString("4ca81b0b-e06d-408e-a991-de140f4e229b")
-    switchBC.allNodes() >> List.of(nodeB, nodeC)
-    def switchCD = Mock(SwitchInput)
-    switchCD.getUuid() >> UUID.fromString("92ce075e-9e3b-4ee6-89b6-19e6372fba01")
-    switchCD.allNodes() >> List.of(nodeC, nodeD)
-
-    def rawGridElements = new RawGridElements([
-      nodeA,
-      nodeB,
-      nodeC,
-      nodeD,
-      nodeE,
-      transformer,
-      switchAB,
-      switchBC,
-      switchCD
-    ])
-
-    def subGrid1 = Mock(SubGridContainer)
-    def subGrid2 = Mock(SubGridContainer)
-    def subGridMapping = [
-      1: subGrid1,
-      2: subGrid2
-    ]
-
-    def expected = new ContainerUtils.TransformerSubGridContainers(subGrid1, subGrid2)
-
-    when:
-    def actual = ContainerUtils.getSubGridContainers(transformer, rawGridElements, subGridMapping)
-
-    then:
-    actual == expected
-  }
 }