fix: enforce zero-warning lint and resolve curly/test warnings

- add braces for single-line conditionals in normalizeMap
- remove unnecessary eslint-disable; use import with targeted ts-ignore
- make lint fail on warnings via --max-warnings=0

Refs: internal quality gate for CI

Author: masterkain

package.json

@@ -45,7 +45,7 @@
     "watch-tests": "tsc -p . -w --outDir out",
     "pretest": "npm run compile-tests && npm run compile && npm run lint",
     "check-types": "tsc --noEmit",
-    "lint": "eslint src",
+    "lint": "eslint src --max-warnings=0",
     "test": "vscode-test",
     "vsce:package": "vsce package",
     "vsce:publish": "vsce publish",

src/extension.ts

@@ -100,12 +100,18 @@ function getCommentSyntax(extension: string): string | null {
 }
 
 function normalizeMap(map: Record<string, string> | undefined): Record<string, string> {
-    if (!map) return {};
+    if (!map) {
+        return {};
+    }
     const out: Record<string, string> = {};
     for (const [k, v] of Object.entries(map)) {
-        if (!k) continue;
+        if (!k) {
+            continue;
+        }
         const key = k.startsWith('.') ? k : `.${k}`;
-        if (typeof v === 'string' && v.trim().length > 0) out[key] = v;
+        if (typeof v === 'string' && v.trim().length > 0) {
+            out[key] = v;
+        }
     }
     return out;
 }

src/test/configOverride.test.ts

@@ -1,8 +1,7 @@
 import * as assert from 'assert';
 import * as vscode from 'vscode';
-
-// eslint-disable-next-line @typescript-eslint/no-var-requires
-const ext = require('../../dist/extension.js');
+// @ts-ignore - importing built CJS bundle for runtime
+import * as ext from '../../dist/extension.js';
 
 suite('Configuration override', () => {
   test('user settings override default map', async () => {
@@ -17,4 +16,3 @@ suite('Configuration override', () => {
     }
   });
 });
-