#294 fixed detekt errors in widgets module

Author: anton6tak

widgets/build.gradle.kts

@@ -4,7 +4,6 @@
 
 plugins {
     id("multiplatform-library-convention")
-    id("dev.icerock.mobile.multiplatform.android-manifest")
     id("publication-convention")
     id("kotlin-kapt")
     id("kotlin-parcelize")

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/Image.kt

@@ -7,6 +7,7 @@ package dev.icerock.moko.widgets.core
 import android.widget.ImageView
 import dev.icerock.moko.resources.ImageResource
 
+@Suppress("UnnecessaryAbstractClass")
 actual abstract class Image {
     abstract fun loadIn(imageView: ImageView)
 

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/PreviewView.kt

@@ -1,3 +1,4 @@
+@file:Suppress("Filename", "MatchingDeclarationName")
 /*
  * Copyright 2019 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license.
  */
@@ -12,7 +13,9 @@ import android.widget.FrameLayout
 import dev.icerock.moko.widgets.core.screen.Screen
 
 abstract class BasePreviewView @JvmOverloads constructor(
-    context: Context, attrs: AttributeSet? = null, defStyleAttr: Int = 0
+    context: Context,
+    attrs: AttributeSet? = null,
+    defStyleAttr: Int = 0
 ) : FrameLayout(context, attrs, defStyleAttr) {
     abstract fun createScreen(): Screen<*>
 

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/AutoScrollListViewFactory.kt

@@ -65,4 +65,4 @@ actual class AutoScrollListViewFactory actual constructor(
             else -> null
         }
     }
-}
+}

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/ButtonWithIconViewFactory.kt

@@ -30,6 +30,7 @@ import dev.icerock.moko.widgets.core.style.view.WidgetSize
 import dev.icerock.moko.widgets.core.utils.bind
 import dev.icerock.moko.widgets.core.widget.ButtonWidget
 
+@Suppress("LongParameterList")
 actual class ButtonWithIconViewFactory actual constructor(
     private val background: PressableState<Background<out Fill>>?,
     private val textStyle: TextStyle<PressableState<Color>>?,
@@ -42,6 +43,7 @@ actual class ButtonWithIconViewFactory actual constructor(
     private val icon: PressableState<ImageResource>
 ) : ViewFactory<ButtonWidget<out WidgetSize>> {
 
+    @Suppress("ComplexMethod", "LongParameterList")
     @SuppressLint("RestrictedApi")
     override fun <WS : WidgetSize> build(
         widget: ButtonWidget<out WidgetSize>,
@@ -60,6 +62,7 @@ actual class ButtonWithIconViewFactory actual constructor(
         val icPadding = iconPadding ?: 0.0f
         val materialThemeWrapper = ContextThemeWrapper(ctx, R.style.Theme_MaterialComponents_NoActionBar)
 
+        @Suppress("TooGenericExceptionThrown")
         val button: MaterialButton = when (widget.content) {
             is ButtonWidget.Content.Text -> {
                 MaterialButton(materialThemeWrapper).apply {

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/CardViewFactory.kt

@@ -68,5 +68,4 @@ actual class CardViewFactory actual constructor(
             margins = margins
         )
     }
-
 }

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/CheckboxSwitchViewFactory.kt

@@ -5,7 +5,6 @@
 package dev.icerock.moko.widgets.core.factory
 
 import android.graphics.drawable.StateListDrawable
-import android.widget.CheckBox
 import androidx.appcompat.widget.AppCompatCheckBox
 import androidx.core.content.ContextCompat
 import dev.icerock.moko.resources.ImageResource

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/ClickableViewFactory.kt

@@ -14,8 +14,7 @@ import dev.icerock.moko.widgets.core.ViewFactoryContext
 import dev.icerock.moko.widgets.core.style.view.WidgetSize
 import dev.icerock.moko.widgets.core.widget.ClickableWidget
 
-actual class ClickableViewFactory actual constructor(
-) : ViewFactory<ClickableWidget<out WidgetSize>> {
+actual class ClickableViewFactory : ViewFactory<ClickableWidget<out WidgetSize>> {
 
     override fun <WS : WidgetSize> build(
         widget: ClickableWidget<out WidgetSize>,

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/ContainerViewFactory.kt

@@ -133,4 +133,4 @@ actual class ContainerViewFactory actual constructor(
             }
         }
     }
-}
+}

widgets/src/androidMain/kotlin/dev/icerock/moko/widgets/core/factory/FloatingLabelInputViewFactory.kt

@@ -40,6 +40,7 @@ import dev.icerock.moko.widgets.core.utils.bind
 import dev.icerock.moko.widgets.core.utils.dp
 import dev.icerock.moko.widgets.core.utils.sp
 
+@Suppress("LongParameterList", "MagicNumber")
 actual class FloatingLabelInputViewFactory actual constructor(
     private val background: Background<Fill.Solid>?,
     private val margins: MarginValues?,
@@ -51,6 +52,7 @@ actual class FloatingLabelInputViewFactory actual constructor(
     private val textHorizontalAlignment: TextHorizontalAlignment?
 ) : ViewFactory<InputWidget<out WidgetSize>> {
 
+    @Suppress("LongMethod", "ComplexMethod")
     @SuppressLint("RestrictedApi")
     override fun <WS : WidgetSize> build(
         widget: InputWidget<out WidgetSize>,
@@ -73,7 +75,8 @@ actual class FloatingLabelInputViewFactory actual constructor(
                 ViewGroup.LayoutParams.MATCH_PARENT,
                 ViewGroup.LayoutParams.WRAP_CONTENT
             ).apply {
-                // EditText's default background have paddings 4dp, while we not change background to own we just change margins
+                // EditText's default background have paddings 4dp,
+                // while we not change background to own we just change margins
                 // https://stackoverflow.com/questions/31735291/removing-the-left-padding-on-an-android-edittext/44497551
                 val dp4 = (-4).dp(context)
                 MarginLayoutParamsCompat.setMarginStart(this, dp4)
@@ -104,18 +107,14 @@ actual class FloatingLabelInputViewFactory actual constructor(
                 if (!hasFocus) widget.field.validate()
             }
             addTextChangedListener(object : TextWatcher {
-                override fun afterTextChanged(s: Editable?) {
-
-                }
+                override fun afterTextChanged(s: Editable?) = Unit
 
                 override fun beforeTextChanged(
                     s: CharSequence?,
                     start: Int,
                     count: Int,
                     after: Int
-                ) {
-
-                }
+                ) = Unit
 
                 override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) {
                     if (s == null) return
@@ -186,5 +185,4 @@ actual class FloatingLabelInputViewFactory actual constructor(
         field.isAccessible = true
         return field.get(this) as CollapsingTextHelper
     }
-
 }