Skip to content

Commit e18e986

Browse files
committed
added suppress for empty constructor and fixed firebase cinterop
1 parent a35e487 commit e18e986

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

crash-reporting-crashlytics/src/androidMain/kotlin/dev/icerock/moko/crashreporting/crashlytics/CrashlyticsLogger.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ package dev.icerock.moko.crashreporting.crashlytics
77
import com.google.firebase.crashlytics.FirebaseCrashlytics
88
import dev.icerock.moko.crashreporting.core.ExceptionLogger
99

10+
@Suppress("EmptyDefaultConstructor")
1011
actual class CrashlyticsLogger actual constructor() : ExceptionLogger {
1112
actual override fun log(message: String) {
1213
FirebaseCrashlytics.getInstance().log(message)

crash-reporting-crashlytics/src/commonMain/kotlin/dev/icerock/moko/crashreporting/crashlytics/CrashlyticsLogger.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package dev.icerock.moko.crashreporting.crashlytics
66

77
import dev.icerock.moko.crashreporting.core.ExceptionLogger
88

9+
@Suppress("EmptyDefaultConstructor")
910
expect class CrashlyticsLogger() : ExceptionLogger {
1011
override fun log(message: String)
1112
override fun recordException(throwable: Throwable)

sample/android-app/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ android {
2020
minSdkVersion(Deps.Android.minSdk)
2121
targetSdkVersion(Deps.Android.targetSdk)
2222

23-
applicationId = "dev.icerock.moko.samples.crashreporting"
23+
applicationId = "dev.icerock.moko.samples.crashreporting.debug"
2424

2525
versionCode = 1
2626
versionName = "0.1.0"
@@ -36,7 +36,6 @@ android {
3636
}
3737
getByName("debug") {
3838
isDebuggable = true
39-
applicationIdSuffix = ".debug"
4039
}
4140
}
4241

sample/mpp-library/build.gradle.kts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,10 @@ framework {
2121
export(project(":crash-reporting-crashlytics"))
2222
export(project(":crash-reporting-napier"))
2323
}
24+
25+
cocoaPods {
26+
podsProject = file("../ios-app/Pods/Pods.xcodeproj")
27+
28+
pod("GoogleUtilities", onlyLink = false)
29+
pod("FirebaseCrashlytics", onlyLink = true)
30+
}

0 commit comments

Comments
 (0)