PHP Linting (Pint)

iamfarhad · github-actions[bot] · commit 5835d0d00265 · 2025-09-10T17:15:13.000Z
diff --git a/src/Rules/Address.php b/src/Rules/Address.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value)) {
             $fail(__('validationRules::messages.address', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/Base64.php b/src/Rules/Base64.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value)) {
             $fail(__('validationRules::messages.base64', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/CardNumber.php b/src/Rules/CardNumber.php
@@ -14,18 +14,20 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.cardNumber', ['attribute' => $attribute]));
+
             return;
         }
 
         $value = (string) $value;
 
         if (! preg_match('#^\d{16}$#', $value)) {
             $fail(__('validationRules::messages.cardNumber', ['attribute' => $attribute]));
+
             return;
         }
 
         $sum = 0;
-        for ($position = 1; $position <= 16; ++$position) {
+        for ($position = 1; $position <= 16; $position++) {
             $temp = (int) $value[$position - 1];
             $temp = $position % 2 === 0 ? $temp : $temp * 2;
             $temp = $temp > 9 ? $temp - 9 : $temp;
diff --git a/src/Rules/IsNotPersian.php b/src/Rules/IsNotPersian.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value)) {
             $fail(__('validationRules::messages.isNotPersian', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/Mobile.php b/src/Rules/Mobile.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.mobile', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/NationalCode.php b/src/Rules/NationalCode.php
@@ -14,29 +14,32 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.nationalCode', ['attribute' => $attribute]));
+
             return;
         }
 
         $value = (string) $value;
 
         if (! preg_match('#^\d{8,10}$#', $value)) {
             $fail(__('validationRules::messages.nationalCode', ['attribute' => $attribute]));
+
             return;
         }
 
         if (preg_match('#^[0]{10}|[1]{10}|[2]{10}|[3]{10}|[4]{10}|[5]{10}|[6]{10}|[7]{10}|[8]{10}|[9]{10}$#', $value)) {
             $fail(__('validationRules::messages.nationalCode', ['attribute' => $attribute]));
+
             return;
         }
 
         $sub = 0;
         if (strlen($value) == 8) {
-            $value = '00' . $value;
+            $value = '00'.$value;
         } elseif (strlen($value) == 9) {
-            $value = '0' . $value;
+            $value = '0'.$value;
         }
 
-        for ($i = 0; $i <= 8; ++$i) {
+        for ($i = 0; $i <= 8; $i++) {
             $sub += $value[$i] * (10 - $i);
         }
 
diff --git a/src/Rules/PersianAlpha.php b/src/Rules/PersianAlpha.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value)) {
             $fail(__('validationRules::messages.persianAlpha', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/PersianNumber.php b/src/Rules/PersianNumber.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.persianNumber', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/Phone.php b/src/Rules/Phone.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.phone', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/PhoneArea.php b/src/Rules/PhoneArea.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.phoneArea', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/PostalCode.php b/src/Rules/PostalCode.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.postalCode', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/Rules/Sheba.php b/src/Rules/Sheba.php
@@ -14,32 +14,37 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value) && ! is_numeric($value)) {
             $fail(__('validationRules::messages.shebaNumber', ['attribute' => $attribute]));
+
             return;
         }
 
         $value = (string) $value;
 
         if (empty($value)) {
             $fail(__('validationRules::messages.shebaNumber', ['attribute' => $attribute]));
+
             return;
         }
 
         $value = preg_replace('#[\W_]+#', '', strtoupper($value));
 
         if (strlen($value) < 4 || strlen($value) > 34) {
             $fail(__('validationRules::messages.shebaNumber', ['attribute' => $attribute]));
+
             return;
         }
 
         // Check first two characters are letters
         if (is_numeric($value[0]) || is_numeric($value[1])) {
             $fail(__('validationRules::messages.shebaNumber', ['attribute' => $attribute]));
+
             return;
         }
 
         // Check next two characters are numbers
         if (! is_numeric($value[2]) || ! is_numeric($value[3])) {
             $fail(__('validationRules::messages.shebaNumber', ['attribute' => $attribute]));
+
             return;
         }
 
@@ -50,12 +55,12 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
             $ibanReplaceValues[] = (string) $tempvalue;
         }
 
-        $tmpIBAN = substr($value, 4) . substr($value, 0, 4);
+        $tmpIBAN = substr($value, 4).substr($value, 0, 4);
         $tmpIBAN = str_replace($ibanReplaceChars, $ibanReplaceValues, $tmpIBAN);
 
         $tmpValue = (int) $tmpIBAN[0];
 
-        for ($i = 1, $iMax = strlen($tmpIBAN); $i < $iMax; ++$i) {
+        for ($i = 1, $iMax = strlen($tmpIBAN); $i < $iMax; $i++) {
             $tmpValue *= 10;
             $tmpValue += (int) $tmpIBAN[$i];
             $tmpValue %= 97;
diff --git a/src/Rules/Username.php b/src/Rules/Username.php
@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
     {
         if (! is_string($value)) {
             $fail(__('validationRules::messages.username', ['attribute' => $attribute]));
+
             return;
         }
 
diff --git a/src/ValidationRulesServiceProvider.php b/src/ValidationRulesServiceProvider.php
@@ -9,7 +9,7 @@ final class ValidationRulesServiceProvider extends ServiceProvider
     public function boot(): void
     {
         $this->publishes([
-            __DIR__.'/../resources/lang' => app()->langPath() . '/vendor/validationRules',
+            __DIR__.'/../resources/lang' => app()->langPath().'/vendor/validationRules',
         ]);
 
         $this->loadTranslationsFrom(__DIR__.'/../resources/lang/', 'validationRules');
diff --git a/tests/Rules/AddressTest.php b/tests/Rules/AddressTest.php
@@ -22,7 +22,7 @@ public function test_valid_addresses(): void
         foreach ($validAddresses as $address) {
             $validator = Validator::make(
                 ['address' => $address],
-                ['address' => [new Address()]]
+                ['address' => [new Address]]
             );
 
             $this->assertTrue($validator->passes(), "Address '{$address}' should be valid");
@@ -45,7 +45,7 @@ public function test_validation_error_message(): void
         // Since Address rule is very permissive, we'll test with a required field
         $validator = Validator::make(
             ['address' => ''],
-            ['address' => ['required', new Address()]]
+            ['address' => ['required', new Address]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/Base64Test.php b/tests/Rules/Base64Test.php
@@ -20,7 +20,7 @@ public function test_valid_base64_strings(): void
         foreach ($validBase64 as $base64) {
             $validator = Validator::make(
                 ['data' => $base64],
-                ['data' => [new Base64()]]
+                ['data' => [new Base64]]
             );
 
             $this->assertTrue($validator->passes(), "Base64 string {$base64} should be valid");
@@ -40,7 +40,7 @@ public function test_invalid_base64_strings(): void
         foreach ($invalidBase64 as $base64) {
             $validator = Validator::make(
                 ['data' => $base64],
-                ['data' => [new Base64()]]
+                ['data' => [new Base64]]
             );
 
             $this->assertFalse($validator->passes(), "String {$base64} should be invalid base64");
@@ -51,7 +51,7 @@ public function test_validation_error_message(): void
     {
         $validator = Validator::make(
             ['data' => 'Hello World'],
-            ['data' => [new Base64()]]
+            ['data' => [new Base64]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/CardNumberTest.php b/tests/Rules/CardNumberTest.php
@@ -19,7 +19,7 @@ public function test_valid_card_numbers(): void
         foreach ($validCards as $card) {
             $validator = Validator::make(
                 ['card_number' => $card],
-                ['card_number' => [new CardNumber()]]
+                ['card_number' => [new CardNumber]]
             );
 
             $this->assertTrue($validator->passes(), "Card number {$card} should be valid");
@@ -40,7 +40,7 @@ public function test_invalid_card_numbers(): void
         foreach ($invalidCards as $card) {
             $validator = Validator::make(
                 ['card_number' => $card],
-                ['card_number' => [new CardNumber()]]
+                ['card_number' => [new CardNumber]]
             );
 
             $this->assertFalse($validator->passes(), "Card number {$card} should be invalid");
@@ -51,7 +51,7 @@ public function test_validation_error_message(): void
     {
         $validator = Validator::make(
             ['card_number' => '4532015112830367'],
-            ['card_number' => [new CardNumber()]]
+            ['card_number' => [new CardNumber]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/IsNotPersianTest.php b/tests/Rules/IsNotPersianTest.php
@@ -21,7 +21,7 @@ public function test_valid_non_persian_text(): void
         foreach ($validTexts as $text) {
             $validator = Validator::make(
                 ['text' => $text],
-                ['text' => [new IsNotPersian()]]
+                ['text' => [new IsNotPersian]]
             );
 
             $this->assertTrue($validator->passes(), "Text '{$text}' should be valid (not Persian)");
@@ -41,7 +41,7 @@ public function test_invalid_persian_text(): void
         foreach ($invalidTexts as $text) {
             $validator = Validator::make(
                 ['text' => $text],
-                ['text' => [new IsNotPersian()]]
+                ['text' => [new IsNotPersian]]
             );
 
             $this->assertFalse($validator->passes(), "Text '{$text}' should be invalid (contains Persian)");
@@ -52,7 +52,7 @@ public function test_validation_error_message(): void
     {
         $validator = Validator::make(
             ['text' => 'سلام'],
-            ['text' => [new IsNotPersian()]]
+            ['text' => [new IsNotPersian]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/MobileTest.php b/tests/Rules/MobileTest.php
@@ -20,7 +20,7 @@ public function test_valid_mobile_numbers(): void
         foreach ($validMobiles as $mobile) {
             $validator = Validator::make(
                 ['mobile' => $mobile],
-                ['mobile' => [new Mobile()]]
+                ['mobile' => [new Mobile]]
             );
 
             $this->assertTrue($validator->passes(), "Mobile {$mobile} should be valid");
@@ -41,7 +41,7 @@ public function test_invalid_mobile_numbers(): void
         foreach ($invalidMobiles as $mobile) {
             $validator = Validator::make(
                 ['mobile' => $mobile],
-                ['mobile' => [new Mobile()]]
+                ['mobile' => [new Mobile]]
             );
 
             $this->assertFalse($validator->passes(), "Mobile {$mobile} should be invalid");
@@ -52,7 +52,7 @@ public function test_validation_error_message(): void
     {
         $validator = Validator::make(
             ['mobile' => '08123456789'],
-            ['mobile' => [new Mobile()]]
+            ['mobile' => [new Mobile]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/NationalCodeTest.php b/tests/Rules/NationalCodeTest.php
@@ -18,7 +18,7 @@ public function test_valid_national_codes(): void
         foreach ($validCodes as $code) {
             $validator = Validator::make(
                 ['national_code' => $code],
-                ['national_code' => [new NationalCode()]]
+                ['national_code' => [new NationalCode]]
             );
 
             $this->assertTrue($validator->passes(), "National code {$code} should be valid");
@@ -39,7 +39,7 @@ public function test_invalid_national_codes(): void
         foreach ($invalidCodes as $code) {
             $validator = Validator::make(
                 ['national_code' => $code],
-                ['national_code' => [new NationalCode()]]
+                ['national_code' => [new NationalCode]]
             );
 
             $this->assertFalse($validator->passes(), "National code {$code} should be invalid");
@@ -50,7 +50,7 @@ public function test_validation_error_message(): void
     {
         $validator = Validator::make(
             ['national_code' => '0112169229'],
-            ['national_code' => [new NationalCode()]]
+            ['national_code' => [new NationalCode]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/PersianAlphaTest.php b/tests/Rules/PersianAlphaTest.php
@@ -21,7 +21,7 @@ public function test_valid_persian_text(): void
         foreach ($validTexts as $text) {
             $validator = Validator::make(
                 ['text' => $text],
-                ['text' => [new PersianAlpha()]]
+                ['text' => [new PersianAlpha]]
             );
 
             $this->assertTrue($validator->passes(), "Persian text '{$text}' should be valid");
@@ -41,7 +41,7 @@ public function test_invalid_persian_text(): void
         foreach ($invalidTexts as $text) {
             $validator = Validator::make(
                 ['text' => $text],
-                ['text' => [new PersianAlpha()]]
+                ['text' => [new PersianAlpha]]
             );
 
             $this->assertFalse($validator->passes(), "Text '{$text}' should be invalid");
@@ -52,7 +52,7 @@ public function test_validation_error_message(): void
     {
         $validator = Validator::make(
             ['text' => 'Hello'],
-            ['text' => [new PersianAlpha()]]
+            ['text' => [new PersianAlpha]]
         );
 
         $this->assertFalse($validator->passes());
diff --git a/tests/Rules/PersianNumberTest.php b/tests/Rules/PersianNumberTest.php
diff --git a/tests/Rules/PhoneAreaTest.php b/tests/Rules/PhoneAreaTest.php
diff --git a/tests/Rules/PhoneTest.php b/tests/Rules/PhoneTest.php
diff --git a/tests/Rules/PostalCodeTest.php b/tests/Rules/PostalCodeTest.php
diff --git a/tests/Rules/ShebaTest.php b/tests/Rules/ShebaTest.php
diff --git a/tests/Rules/UsernameTest.php b/tests/Rules/UsernameTest.php

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void`
`14`	`14`	`{`
`15`	`15`	`if (! is_string($value)) {`
`16`	`16`	`$fail(__('validationRules::messages.address', ['attribute' => $attribute]));`
	`17`	`+`
`17`	`18`	`return;`
`18`	`19`	`}`
`19`	`20`
Original file line number	Diff line number	Diff line change
`@@ -14,18 +14,20 @@ public function validate(string $attribute, mixed $value, Closure $fail): void`
`14`	`14`	`{`
`15`	`15`	`if (! is_string($value) && ! is_numeric($value)) {`
`16`	`16`	`$fail(__('validationRules::messages.cardNumber', ['attribute' => $attribute]));`
	`17`	`+`
`17`	`18`	`return;`
`18`	`19`	`}`
`19`	`20`
`20`	`21`	`$value = (string) $value;`
`21`	`22`
`22`	`23`	`if (! preg_match('#^\d{16}$#', $value)) {`
`23`	`24`	`$fail(__('validationRules::messages.cardNumber', ['attribute' => $attribute]));`
	`25`	`+`
`24`	`26`	`return;`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`$sum = 0;`
`28`		`- for ($position = 1; $position <= 16; ++$position) {`
	`30`	`+ for ($position = 1; $position <= 16; $position++) {`
`29`	`31`	`$temp = (int) $value[$position - 1];`
`30`	`32`	`$temp = $position % 2 === 0 ? $temp : $temp * 2;`
`31`	`33`	`$temp = $temp > 9 ? $temp - 9 : $temp;`
Original file line number	Diff line number	Diff line change
`@@ -14,29 +14,32 @@ public function validate(string $attribute, mixed $value, Closure $fail): void`
`14`	`14`	`{`
`15`	`15`	`if (! is_string($value) && ! is_numeric($value)) {`
`16`	`16`	`$fail(__('validationRules::messages.nationalCode', ['attribute' => $attribute]));`
	`17`	`+`
`17`	`18`	`return;`
`18`	`19`	`}`
`19`	`20`
`20`	`21`	`$value = (string) $value;`
`21`	`22`
`22`	`23`	`if (! preg_match('#^\d{8,10}$#', $value)) {`
`23`	`24`	`$fail(__('validationRules::messages.nationalCode', ['attribute' => $attribute]));`
	`25`	`+`
`24`	`26`	`return;`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`if (preg_match('#^[0]{10}\|[1]{10}\|[2]{10}\|[3]{10}\|[4]{10}\|[5]{10}\|[6]{10}\|[7]{10}\|[8]{10}\|[9]{10}$#', $value)) {`
`28`	`30`	`$fail(__('validationRules::messages.nationalCode', ['attribute' => $attribute]));`
	`31`	`+`
`29`	`32`	`return;`
`30`	`33`	`}`
`31`	`34`
`32`	`35`	`$sub = 0;`
`33`	`36`	`if (strlen($value) == 8) {`
`34`		`- $value = '00' . $value;`
	`37`	`+ $value = '00'.$value;`
`35`	`38`	`} elseif (strlen($value) == 9) {`
`36`		`- $value = '0' . $value;`
	`39`	`+ $value = '0'.$value;`
`37`	`40`	`}`
`38`	`41`
`39`		`- for ($i = 0; $i <= 8; ++$i) {`
	`42`	`+ for ($i = 0; $i <= 8; $i++) {`
`40`	`43`	`$sub += $value[$i] * (10 - $i);`
`41`	`44`	`}`
`42`	`45`