[yugabyte#25559] YSQL: Fix order in some queries with IN clause

Summary:
It was incorrectly assumed that requests with equality conditions on
all key columns, when those conditions are converted to ybctid, do not
need to keep the row order.
It is true in most cases, basically, because those conditions usually
produce single ybctid, and yield at most one row.
However, there is one exception, when it is not true. If one column's
equality condition is an IN operator, it yields multiple ybctids, which
order may be important.
Fixed by providing the keep_order parameter.
Jira: DB-14813

Test Plan: ./yb_build.sh --java-test org.yb.pgsql.TestPgRegressHashInQueries#schedule

Reviewers: dmitry, telgersma

Reviewed By: telgersma

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D41145

Author: andrei-mart

src/postgres/src/test/regress/expected/yb_hash_in_queries.out

@@ -964,12 +964,12 @@ SELECT * FROM in_with_single_asc_key WHERE r IN (1, 3, 2, 102, 103, 101) ORDER B
 SELECT * FROM in_with_single_asc_key WHERE r IN (1, 3, 2, 102, 103, 101) ORDER BY r DESC;
   r  |  v
 -----+-----
-   3 |   3
-   2 |   2
-   1 |   1
  103 | 103
  102 | 102
  101 | 101
+   3 |   3
+   2 |   2
+   1 |   1
 (6 rows)
 
 DROP TABLE in_with_single_asc_key;
@@ -978,12 +978,12 @@ INSERT INTO in_with_single_desc_key VALUES(1, 1), (3, 3), (2, 2), (101, 101), (1
 SELECT * FROM in_with_single_desc_key WHERE r IN (1, 3, 2, 102, 103, 101) ORDER BY r ASC;
   r  |  v
 -----+-----
- 101 | 101
- 102 | 102
- 103 | 103
    1 |   1
    2 |   2
    3 |   3
+ 101 | 101
+ 102 | 102
+ 103 | 103
 (6 rows)
 
 SELECT * FROM in_with_single_desc_key WHERE r IN (1, 3, 2, 102, 103, 101) ORDER BY r DESC;
@@ -1003,12 +1003,12 @@ INSERT INTO in_with_compound_asc_key VALUES(1, 1, 1), (1, 3, 3), (1, 2, 2), (1,
 SELECT * FROM in_with_compound_asc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 DESC, r2 DESC;
  r1 | r2  |  v
 ----+-----+-----
-  1 |   3 |   3
-  1 |   2 |   2
-  1 |   1 |   1
   1 | 103 | 103
   1 | 102 | 102
   1 | 101 | 101
+  1 |   3 |   3
+  1 |   2 |   2
+  1 |   1 |   1
 (6 rows)
 
 SELECT * FROM in_with_compound_asc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 DESC, r2 ASC;
@@ -1025,12 +1025,12 @@ SELECT * FROM in_with_compound_asc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103
 SELECT * FROM in_with_compound_asc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 ASC, r2 DESC;
  r1 | r2  |  v
 ----+-----+-----
-  1 |   3 |   3
-  1 |   2 |   2
-  1 |   1 |   1
   1 | 103 | 103
   1 | 102 | 102
   1 | 101 | 101
+  1 |   3 |   3
+  1 |   2 |   2
+  1 |   1 |   1
 (6 rows)
 
 SELECT * FROM in_with_compound_asc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 ASC, r2 ASC;
@@ -1061,12 +1061,12 @@ SELECT * FROM in_with_compound_desc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 10
 SELECT * FROM in_with_compound_desc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 DESC, r2 ASC;
  r1 | r2  |  v
 ----+-----+-----
-  1 | 101 | 101
-  1 | 102 | 102
-  1 | 103 | 103
   1 |   1 |   1
   1 |   2 |   2
   1 |   3 |   3
+  1 | 101 | 101
+  1 | 102 | 102
+  1 | 103 | 103
 (6 rows)
 
 SELECT * FROM in_with_compound_desc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 ASC, r2 DESC;
@@ -1083,12 +1083,12 @@ SELECT * FROM in_with_compound_desc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 10
 SELECT * FROM in_with_compound_desc_key WHERE r1 = 1 AND r2 IN (1, 3, 2, 102, 103, 101) ORDER BY r1 ASC, r2 ASC;
  r1 | r2  |  v
 ----+-----+-----
-  1 | 101 | 101
-  1 | 102 | 102
-  1 | 103 | 103
   1 |   1 |   1
   1 |   2 |   2
   1 |   3 |   3
+  1 | 101 | 101
+  1 | 102 | 102
+  1 | 103 | 103
 (6 rows)
 
 DROP TABLE in_with_compound_desc_key;

src/yb/yql/pggate/pg_dml_read.cc

@@ -721,7 +721,7 @@ Status PgDmlRead::SubstitutePrimaryBindsWithYbctids(const PgExecParameters* para
   read_req_->mutable_partition_column_values()->clear();
   read_req_->mutable_range_column_values()->clear();
   RETURN_NOT_OK(InitDocOp(params, /* is_concrete_row_read = */ true));
-  return UpdateRequestWithYbctids(ybctids);
+  return UpdateRequestWithYbctids(ybctids, KeepOrder(read_req_->has_is_forward_scan()));
 }
 
 // Function builds vector of ybctids from primary key binds.