Skip to content

Commit ea0244a

Browse files
[yugabyte#27526] Docdb: Test. Fix flakieness in PgMiniTestTracing.Tracing seen in tsan
Summary: a0e6d55 refactored PgMiniTestTracing.Tracing to make it a parameterized test, and in the process set the flag `enable_tracing=true`. Setting the flag to `true` is not necessary and makes the test flaky in slow tests. Slow tests (with enable_tracing set to true) may cause unrelated rpcs traces to get logged, This makes the test flacky as the test expects that the latest trace dumped has to be a certain size. Setting `enable_tracing` to `false` prevents the flakieness as only the rpcs originating from the session in the test will log the traces. Jira: DB-17087 Test Plan: Jenkins: test regex: PgMiniTestTracing/PgMiniTestTracing.Tracing/* yb_buid.sh --cxx-test pgwrapper_pg_mini-test --gtest_filter PgMiniTestTracing/PgMiniTestTracing.Tracing/* Reviewers: bkolagani, rthallam Reviewed By: bkolagani Subscribers: ybase, yql Differential Revision: https://phorge.dev.yugabyte.com/D44598
1 parent 988a83c commit ea0244a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/yb/yql/pgwrapper/pg_mini-test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ TEST_F(PgMiniTest, Simple) {
553553
class PgMiniTestTracing : public PgMiniTest, public ::testing::WithParamInterface<bool> {
554554
protected:
555555
void SetUp() override {
556-
ANNOTATE_UNPROTECTED_WRITE(FLAGS_enable_tracing) = true;
556+
ANNOTATE_UNPROTECTED_WRITE(FLAGS_enable_tracing) = false;
557557
ANNOTATE_UNPROTECTED_WRITE(FLAGS_tracing_level) = 1;
558558
ANNOTATE_UNPROTECTED_WRITE(FLAGS_pg_client_use_shared_memory) = GetParam();
559559
PgMiniTest::SetUp();

0 commit comments

Comments
 (0)