[BACKPORT-2024.1][PLAT-14858][PLAT-14822] [Retryability]fault injection tests for smartResize are failing

Summary:
Fixed resize node retries and added unit test.
Original diff: b4fd3fc/D37026

Test Plan: sbt test

Reviewers: nsingh, cwang, svarshney

Reviewed By: svarshney

Subscribers: yugaware, cwang

Differential Revision: https://phorge.dev.yugabyte.com/D37568

Author: yorq

managed/src/main/java/com/yugabyte/yw/commissioner/UpgradeTaskBase.java

@@ -436,9 +436,6 @@ private void createRollingUpgradeTaskFlow(
         }
       }
 
-      if (context.postAction != null) {
-        context.postAction.accept(node);
-      }
       // Run post node upgrade hooks
       createHookTriggerTasks(singletonNodeList, false, true);
       createSetNodeStateTask(node, NodeState.Live).setSubTaskGroupType(subGroupType);
@@ -447,6 +444,10 @@ private void createRollingUpgradeTaskFlow(
           taskParams().getUniverseUUID(),
           processTypes,
           SetNodeState.getStartKey(node.getNodeName(), nodeState));
+
+      if (context.postAction != null) {
+        context.postAction.accept(node);
+      }
     }
 
     if (!isLoadBalancerOn) {

managed/src/test/java/com/yugabyte/yw/commissioner/tasks/upgrade/ResizeNodeTest.java

@@ -29,11 +29,13 @@
 import com.yugabyte.yw.commissioner.tasks.UniverseTaskBase.ServerType;
 import com.yugabyte.yw.common.ApiUtils;
 import com.yugabyte.yw.common.PlacementInfoUtil;
+import com.yugabyte.yw.common.TestUtils;
 import com.yugabyte.yw.common.gflags.SpecificGFlags;
 import com.yugabyte.yw.common.utils.Pair;
 import com.yugabyte.yw.forms.ResizeNodeParams;
 import com.yugabyte.yw.forms.UniverseDefinitionTaskParams;
 import com.yugabyte.yw.forms.UpgradeTaskParams;
+import com.yugabyte.yw.models.CustomerTask;
 import com.yugabyte.yw.models.InstanceType;
 import com.yugabyte.yw.models.RuntimeConfigEntry;
 import com.yugabyte.yw.models.TaskInfo;
@@ -1369,6 +1371,25 @@ public void testResetInstanceForAZ() {
     }
   }
 
+  @Test
+  public void testResizeNodeRetries() {
+    ResizeNodeParams taskParams = new ResizeNodeParams();
+    taskParams.expectedUniverseVersion = -1;
+    taskParams.setUniverseUUID(defaultUniverse.getUniverseUUID());
+    taskParams.creatingUser = defaultUser;
+    taskParams.clusters = defaultUniverse.getUniverseDetails().clusters;
+    taskParams.clusters.get(0).userIntent.instanceType = NEW_INSTANCE_TYPE;
+    TestUtils.setFakeHttpContext(defaultUser);
+    super.verifyTaskRetries(
+        defaultCustomer,
+        CustomerTask.TaskType.ResizeNode,
+        CustomerTask.TargetType.Universe,
+        defaultUniverse.getUniverseUUID(),
+        TaskType.ResizeNode,
+        taskParams,
+        false);
+  }
+
   private void assertUniverseData(boolean increaseVolume, boolean changeInstance) {
     assertUniverseData(increaseVolume, changeInstance, true, false);
   }
@@ -1666,7 +1687,7 @@ private void createTasksTypesForNode(
       taskTypesSequence.add(index++, TaskType.CheckFollowerLag);
     }
     if (changeInstance) {
-      taskTypesSequence.add(index++, TaskType.UpdateNodeDetails);
+      taskTypesSequence.add(index + 2, TaskType.UpdateNodeDetails);
     }
   }