[yugabyte#5592] Do not set YB_HOME_DIR in onprem provider config if empty

Summary:
This changed in
yugabyte@42cc19e. This diff changes the java and python code to handle an empty YB_HOME_DIR better but also removes the empty YB_HOME_DIR if it was not set by the user. This is consistent with the way other providers take optional parameters.

Test Plan:
1. Create an onprem provider with an home dir set, verify
it goes through and that YB_HOME_DIR is not set.
2. Create a provider without the UI fix. Check that YB_HOME_DIR is set
to empty in the provider. Create a universe with this provider, verify
it goes through.

Reviewers: wesley, daniel

Reviewed By: daniel

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D9316

Author: iSignal

managed/devops/opscli/ybops/utils/__init__.py

@@ -54,7 +54,7 @@
 RELEASE_REPOS = set(["devops", "yugaware", "yugabyte"])
 
 # Home directory of node instances. Try to read home dir from env, else assume it's /home/yugabyte.
-YB_HOME_DIR = os.environ.get("YB_HOME_DIR", "/home/yugabyte")
+YB_HOME_DIR = os.environ.get("YB_HOME_DIR") or "/home/yugabyte"
 
 
 class ReleasePackage(object):

managed/src/main/java/com/yugabyte/yw/models/Provider.java

@@ -95,7 +95,11 @@ public Map<String, String> getConfig() {
 
   @JsonIgnore
   public String getYbHome() {
-    return this.getConfig().getOrDefault("YB_HOME_DIR", DEFAULT_YB_HOME_DIR);
+    String ybHomeDir = this.getConfig().getOrDefault("YB_HOME_DIR", "");
+    if (ybHomeDir.isEmpty()) {
+      ybHomeDir = DEFAULT_YB_HOME_DIR;
+    }
+    return ybHomeDir;
   }
 
   /**

managed/ui/src/components/config/OnPrem/wizard/OnPremProviderAndAccessKeyContainer.js

@@ -38,8 +38,7 @@ const mapStateToProps = (state, ownProps) => {
     sshPort: 54422,
     passwordlessSudoAccess: true,
     airGapInstall: false,
-    useHostnames: false,
-    homeDir: ""
+    useHostnames: false
   };
   const {cloud: {onPremJsonFormData}} = state;
   if (ownProps.isEditProvider && isNonEmptyObject(onPremJsonFormData)) {