[yugabyte#8354] [Platform][API] Audit controller error handling. (yugabyte#8355)

Description:
Use the new global exception handling in the audit controller.

Test Plan:
It's mostly refactor. Unit tests are updated.
Run server and test basic operations.
Created a new alert in profile section

Reviewers: Shashank. 
Reviewed by : Shashank.

Author: mahendranbhat

managed/src/main/java/com/yugabyte/yw/common/audit/AuditService.java

@@ -128,6 +128,10 @@ public List<Audit> getAllUserEntries(UUID userUUID) {
     return Audit.getAllUserEntries(userUUID);
   }
 
+  public Audit getOrBadRequest(UUID customerUUID, UUID taskUUID) {
+    return Audit.getOrBadRequest(customerUUID, taskUUID);
+  }
+
   public static JsonNode filterSecretFields(JsonNode input) {
     if (input == null) {
       return null;

managed/src/main/java/com/yugabyte/yw/controllers/AuditController.java

@@ -25,21 +25,10 @@ public class AuditController extends AuthenticatedController {
    * @return JSON response with audit entries belonging to the user.
    */
   public Result list(UUID customerUUID, UUID userUUID) {
-    Customer customer = Customer.get(customerUUID);
-    if (customer == null) {
-      return ApiResponse.error(BAD_REQUEST, "Invalid Customer UUID: " + customerUUID);
-    }
-    Users user = Users.get(userUUID);
-    if (user == null) {
-      return ApiResponse.error(BAD_REQUEST, "Invalid User UUID: " + customerUUID);
-    }
-
-    try {
-      List<Audit> auditList = auditService().getAllUserEntries(user.uuid);
-      return ApiResponse.success(auditList);
-    } catch (Exception e) {
-      return ApiResponse.error(INTERNAL_SERVER_ERROR, "Unable to fetch audit history.");
-    }
+    Customer.getOrBadRequest(customerUUID);
+    Users user = Users.getOrBadRequest(userUUID);
+    List<Audit> auditList = auditService().getAllUserEntries(user.uuid);
+    return ApiResponse.success(auditList);
   }
 
   /**
@@ -48,41 +37,15 @@ public Result list(UUID customerUUID, UUID userUUID) {
    * @return JSON response with the corresponding audit entry.
    */
   public Result getTaskAudit(UUID customerUUID, UUID taskUUID) {
-    Customer customer = Customer.get(customerUUID);
-    if (customer == null) {
-      return ApiResponse.error(BAD_REQUEST, "Invalid Customer UUID: " + customerUUID);
-    }
-    try {
-      Audit entry = auditService().getFromTaskUUID(taskUUID);
-      if (entry.getCustomerUUID().equals(customerUUID)) {
-        return ApiResponse.success(entry);
-      } else {
-        return ApiResponse.error(
-            BAD_REQUEST,
-            String.format("Task %s does not belong to customer %s", taskUUID, customerUUID));
-      }
-    } catch (Exception e) {
-      return ApiResponse.error(INTERNAL_SERVER_ERROR, "Unable to fetch audit entry.");
-    }
+    Customer.getOrBadRequest(customerUUID);
+    Audit entry = auditService().getOrBadRequest(customerUUID, taskUUID);
+    return ApiResponse.success(entry);
   }
 
   public Result getUserFromTask(UUID customerUUID, UUID taskUUID) {
-    Customer customer = Customer.get(customerUUID);
-    if (customer == null) {
-      return ApiResponse.error(BAD_REQUEST, "Invalid Customer UUID: " + customerUUID);
-    }
-    try {
-      Audit entry = auditService().getFromTaskUUID(taskUUID);
-      Users user = Users.get(entry.getUserUUID());
-      if (entry.getCustomerUUID().equals(customerUUID)) {
-        return ApiResponse.success(user);
-      } else {
-        return ApiResponse.error(
-            BAD_REQUEST,
-            String.format("Task %s does not belong to customer %s", taskUUID, customerUUID));
-      }
-    } catch (Exception e) {
-      return ApiResponse.error(INTERNAL_SERVER_ERROR, "Unable to fetch user.");
-    }
+    Customer.getOrBadRequest(customerUUID);
+    Audit entry = auditService().getOrBadRequest(customerUUID, taskUUID);
+    Users user = Users.get(entry.getUserUUID());
+    return ApiResponse.success(user);
   }
 }

managed/src/main/java/com/yugabyte/yw/models/Audit.java

@@ -3,6 +3,7 @@
 package com.yugabyte.yw.models;
 
 import com.fasterxml.jackson.databind.JsonNode;
+import com.yugabyte.yw.common.YWServiceException;
 import io.ebean.Finder;
 import io.ebean.Model;
 import io.ebean.annotation.CreatedTimestamp;
@@ -18,6 +19,8 @@
 import java.util.UUID;
 import java.util.function.Consumer;
 
+import static play.mvc.Http.Status.BAD_REQUEST;
+
 @Entity
 public class Audit extends Model {
 
@@ -134,6 +137,17 @@ public static Audit getFromTaskUUID(UUID taskUUID) {
     return find.query().where().eq("task_uuid", taskUUID).findOne();
   }
 
+  public static Audit getOrBadRequest(UUID customerUUID, UUID taskUUID) {
+    Customer.getOrBadRequest(customerUUID);
+    Audit entry =
+        find.query().where().eq("task_uuid", taskUUID).eq("customer_uuid", customerUUID).findOne();
+    if (entry == null) {
+      throw new YWServiceException(
+          BAD_REQUEST, "Task " + taskUUID + " does not belong to customer " + customerUUID);
+    }
+    return entry;
+  }
+
   public static List<Audit> getAllUserEntries(UUID userUUID) {
     return find.query().where().eq("user_uuid", userUUID).findList();
   }

managed/src/test/java/com/yugabyte/yw/controllers/AuditControllerTest.java

@@ -16,6 +16,7 @@
 import com.yugabyte.yw.common.FakeApiHelper;
 import com.yugabyte.yw.common.CallHomeManager.CollectionLevel;
 import com.yugabyte.yw.common.ModelFactory;
+import com.yugabyte.yw.common.YWServiceException;
 import com.yugabyte.yw.metrics.MetricQueryHelper;
 import com.yugabyte.yw.models.Audit;
 import com.yugabyte.yw.models.Customer;
@@ -132,9 +133,13 @@ public void testGetTaskInfoInvalidCustomer() throws IOException {
     Http.Cookie validCookie = Http.Cookie.builder("authToken", authToken2).build();
     String route = "/api/customers/%s/tasks/%s/audit_info";
     Result result =
-        route(
-            fakeRequest("GET", String.format(route, customer2.uuid, taskUUID1))
-                .cookie(validCookie));
+        assertThrows(
+                YWServiceException.class,
+                () ->
+                    route(
+                        fakeRequest("GET", String.format(route, customer2.uuid, taskUUID1))
+                            .cookie(validCookie)))
+            .getResult();
     JsonNode json = Json.parse(contentAsString(result));
     assertEquals(BAD_REQUEST, result.status());
   }
@@ -157,9 +162,13 @@ public void testGetUserFromTaskInvalidCustomer() throws IOException {
     Http.Cookie validCookie = Http.Cookie.builder("authToken", authToken2).build();
     String route = "/api/customers/%s/tasks/%s/audit_user";
     Result result =
-        route(
-            fakeRequest("GET", String.format(route, customer2.uuid, taskUUID1))
-                .cookie(validCookie));
+        assertThrows(
+                YWServiceException.class,
+                () ->
+                    route(
+                        fakeRequest("GET", String.format(route, customer2.uuid, taskUUID1))
+                            .cookie(validCookie)))
+            .getResult();
     JsonNode json = Json.parse(contentAsString(result));
     assertEquals(BAD_REQUEST, result.status());
   }