[PLAT-17135] Pick correct thirdparty directory when installing clockbound service

Summary:
The run template for clockbound had wrong location for thirdparty directory which
fetches the clockbound tar zip. Fixed to usee the correct directory.

Test Plan: Tested by deploying universe.

Reviewers: anijhawan, nsingh, svarshney

Reviewed By: nsingh, svarshney

Differential Revision: https://phorge.dev.yugabyte.com/D42737

Author: Cloud User

managed/node-agent/resources/ynp/modules/provision/clockbound/templates/run.j2

@@ -55,13 +55,20 @@ fi
 clockbound_gz="clockbound-linux-${arch}.tar.gz"
 echo "Using clockbound package ${clockbound_gz}"
 
+if [[ -z "{{ package_path | default('') }}" ]]; then
+  package_path="{{ ynp_dir }}/../../thirdparty"
+else
+  package_path="{{ package_path }}"
+fi
+
 local_path="/usr/local"
 local_bin_path="/usr/local/bin"
 clockbound_binary="clockbound"
 clockbound_check_binary="clockbound-check"
 
 echo "Extracting clockbound and clockbound-check binary"
-tar -xvzf {{ package_path }}/"${clockbound_gz}" -C "${local_path}"
+echo "Untaring to ${package_path}/${clockbound_gz}"
+tar -xvzf "${package_path}/${clockbound_gz}" -C "${local_path}"
 
 echo "Linking clockbound and clockbound-check to ${local_bin_path}"
 ln -sf "${local_path}/${clockbound_binary}" "${local_bin_path}/${clockbound_binary}"
@@ -76,7 +83,7 @@ else
     echo "chrony user neither chrony nor _chrony, exiting"
     exit 1
 fi
-echo "Making ${chrony_user} owner of ${local_bin_path}/${clockbound_binary}"
+echo "Making ${chrony_user} user owner of ${local_bin_path}/${clockbound_binary}"
 chown "${chrony_user}":"${chrony_user}" "${local_bin_path}/${clockbound_binary}"
 
 # Add systemd unit file for clockbound

managed/node-agent/resources/ynp/modules/provision/node_exporter/templates/run.j2

@@ -1,7 +1,8 @@
-thirdparty_dir="{{ ynp_dir }}/../../thirdparty"
-{% if cloud_type is defined and cloud_type != '' %}
-    thirdparty_dir="{{ ynp_dir }}/../thirdparty"
-{% endif %}
+if [[ -z "{{ package_path | default('') }}" ]]; then
+  package_path="{{ ynp_dir }}/../../thirdparty"
+else
+  package_path="{{ package_path }}"
+fi
 
 # Setup the directories & permissions for prometheus user
 mkdir -p /opt/prometheus
@@ -26,10 +27,10 @@ else
 fi
 
 # Copy the appropriate package if it exists
-if [ -f "$thirdparty_dir/$node_exporter_package" ]; then
-    cp "$thirdparty_dir/$node_exporter_package" /opt/prometheus
+if [ -f "$package_path/$node_exporter_package" ]; then
+    cp "$package_path/$node_exporter_package" /opt/prometheus
 else
-    echo "Error: $node_exporter_package not found in $thirdparty_dir"
+    echo "Error: $node_exporter_package not found in $package_path"
     exit 1
 fi