[yugabyte#9209] Platform: Add Unit tests for universe

Summary:
Add unit tests for new API and also add one for downloadNodeLogs that is not a new API but the test was never added.
Fixed the issue introduced because try with resource does not work well with play framework's way of returning input stream.
Also fixed list with name filter in new API.

Test Plan: The diff is all about adding unit tests

Reviewers: spotachev

Reviewed By: spotachev

Subscribers: hsu, jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D12260

Author: sb-yb

managed/src/main/java/com/yugabyte/yw/common/NodeUniverseManager.java

@@ -45,7 +45,8 @@ public synchronized ShellResponse downloadNodeLogs(
       commandArgs.add("--namespace");
       commandArgs.add(namespace);
     } else if (!getNodeDeploymentMode(node, universe).equals(Common.CloudType.unknown)) {
-      AccessKey accessKey = AccessKey.get(providerUUID, cluster.userIntent.accessKeyCode);
+      AccessKey accessKey =
+          AccessKey.getOrBadRequest(providerUUID, cluster.userIntent.accessKeyCode);
       commandArgs.add("ssh");
       commandArgs.add("--port");
       commandArgs.add(accessKey.getKeyInfo().sshPort.toString());

managed/src/main/java/com/yugabyte/yw/controllers/UniverseInfoController.java

@@ -33,7 +33,7 @@
 
 import java.io.File;
 import java.io.FileInputStream;
-import java.io.IOException;
+import java.io.FileNotFoundException;
 import java.io.InputStream;
 import java.util.List;
 import java.util.UUID;
@@ -172,22 +172,27 @@ public Result healthCheck(UUID customerUUID, UUID universeUUID) {
    * @param nodeName name of the node
    * @return tar file of the tserver and master log files (if the node is a master server).
    */
-  // TODO: API
+  @ApiOperation(value = "download Node logs", produces = "application/x-compressed")
   public CompletionStage<Result> downloadNodeLogs(
       UUID customerUUID, UUID universeUUID, String nodeName) {
     return CompletableFuture.supplyAsync(
         () -> {
           File file =
               universeInfoHandler.downloadNodeLogs(customerUUID, universeUUID, nodeName).toFile();
-          try (InputStream is = new FileInputStream(file)) {
-            file.delete(); // TODO: should this be done in finally?
-            // return the file to client
-            response().setHeader("Content-Disposition", "attachment; filename=" + file.getName());
-            return ok(is).as("application/x-compressed");
-          } catch (IOException e) {
-            throw new YWServiceException(INTERNAL_SERVER_ERROR, e.getMessage());
-          }
+          InputStream is = getInputStreamOrFail(file);
+          file.delete(); // TODO: should this be done in finally?
+          // return the file to client
+          response().setHeader("Content-Disposition", "attachment; filename=" + file.getName());
+          return ok(is).as("application/x-compressed");
         },
         ec.current());
   }
+
+  private static InputStream getInputStreamOrFail(File file) {
+    try {
+      return new FileInputStream(file);
+    } catch (FileNotFoundException e) {
+      throw new YWServiceException(INTERNAL_SERVER_ERROR, e.getMessage());
+    }
+  }
 }

managed/src/main/java/com/yugabyte/yw/controllers/handlers/UniverseInfoHandler.java

@@ -41,8 +41,7 @@
 import java.util.UUID;
 import java.util.stream.Collectors;
 
-import static play.mvc.Http.Status.BAD_REQUEST;
-import static play.mvc.Http.Status.INTERNAL_SERVER_ERROR;
+import static play.mvc.Http.Status.*;
 
 @Slf4j
 public class UniverseInfoHandler {
@@ -187,7 +186,10 @@ public Path downloadNodeLogs(UUID customerUUID, UUID universeUUID, String nodeNa
     Customer customer = Customer.getOrBadRequest(customerUUID);
     Universe universe = Universe.getValidUniverseOrBadRequest(universeUUID, customer);
     log.debug("Retrieving logs for " + nodeName);
-    NodeDetails node = universe.getNode(nodeName);
+    NodeDetails node =
+        universe
+            .maybeGetNode(nodeName)
+            .orElseThrow(() -> new YWServiceException(NOT_FOUND, nodeName));
     String storagePath = runtimeConfigFactory.staticApplicationConf().getString("yb.storage.path");
     String tarFileName = node.cloudInfo.private_ip + "-logs.tar.gz";
     Path targetFile = Paths.get(storagePath + "/" + tarFileName);

managed/src/main/java/com/yugabyte/yw/models/Universe.java

@@ -262,7 +262,11 @@ public static Universe getUniverseByName(String universeName) {
   }
 
   public static Optional<Universe> maybeGetUniverseByName(String universeName) {
-    return find.query().where().eq("name", universeName).findOneOrEmpty();
+    return find.query()
+        .where()
+        .eq("name", universeName)
+        .findOneOrEmpty()
+        .map(Universe::fillUniverseDetails);
   }
 
   /**
@@ -810,7 +814,7 @@ static boolean isUniversePaused(UUID uuid) {
     return universe.getUniverseDetails().universePaused;
   }
 
-  private static void fillUniverseDetails(Universe universe) {
+  private static Universe fillUniverseDetails(Universe universe) {
     JsonNode detailsJson = Json.parse(universe.universeDetailsJson);
     universe.universeDetails = Json.fromJson(detailsJson, UniverseDefinitionTaskParams.class);
 
@@ -825,5 +829,6 @@ private static void fillUniverseDetails(Universe universe) {
           Json.fromJson(detailsJson.get("placementInfo"), PlacementInfo.class);
       universe.universeDetails.upsertPrimaryCluster(userIntent, placementInfo);
     }
+    return universe;
   }
 }