Skip to content

Commit 635a95e

Browse files
committed
[yugabyte#29317] DocDB: Upgrade object locking flag to a regular non runtime flag
Summary: Promote the object locking preview flag to a regular flag. The feature would be controlled by a combination of the autoflag `enable_object_locking_infra` and the non runtime flag `enable_object_locking_for_table_locks`. Note: The autoflag `enable_object_locking_infra` will be enabled in 2025.2 by default (and cannot be modified by user), but `enable_object_locking_for_table_locks` flag can be toggled to control the feature as desired. Test Plan: Jenkins Reviewers: rthallam, amitanand, stiwary Reviewed By: rthallam Subscribers: stiwary, yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D48184
1 parent 894cb2e commit 635a95e

File tree

48 files changed

+7
-129
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+7
-129
lines changed

docs/content/stable/explore/transactions/explicit-locking.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ To prevent dead TServers holding locks from permanently blocking subsequent DMLs
136136

137137
Table-level locks are disabled by default. To enable the feature, set the [yb-tserver](../../../reference/configuration/yb-tserver/) flag `enable_object_locking_for_table_locks` to true.
138138

139-
Because `enable_object_locking_for_table_locks` is a preview flag, to use it, add the flag to the [allowed_preview_flags_csv](../../../reference/configuration/yb-tserver/#allowed-preview-flags-csv) list (that is, `allowed_preview_flags_csv=enable_object_locking_for_table_locks`).
140-
141139
As the table-level locks feature depends on Transactional DDL (currently not enabled by default), you need to enable the preview flag, [ysql_yb_ddl_transaction_block_enabled](../transactional-ddl/#enable-transactional-ddl).
142140

143141
For more information on the lock scopes and lifecycle, see [Table-level locks](../../../architecture/transactions/concurrency-control/#table-level-locks).

java/yb-pgsql/src/test/java/org/yb/pgsql/TestAlterTableWithConcurrentTxn.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ protected Map<String, String> getTServerFlags() {
4040
// The test suite asserts for DML failing when run in concurrent to ALTER,
4141
// and doesn't expect proper wait-on behavior for DML-DDL interaction.
4242
Map<String, String> flagMap = super.getTServerFlags();
43-
flagMap.put("allowed_preview_flags_csv", "enable_object_locking_for_table_locks");
4443
flagMap.put("enable_object_locking_for_table_locks", "false");
4544
return flagMap;
4645
}

java/yb-pgsql/src/test/java/org/yb/pgsql/TestDdlSavepoints.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,11 @@ protected void customizeMiniClusterBuilder(MiniYBClusterBuilder builder) {
3434
builder.enablePgTransactions(true);
3535
builder.addCommonTServerFlag("ysql_log_statement", "all");
3636
builder.addCommonTServerFlag("ysql_yb_ddl_transaction_block_enabled", "true");
37-
builder.addCommonTServerFlag("allowed_preview_flags_csv",
38-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
3937
builder.addCommonTServerFlag("enable_object_locking_for_table_locks", "true");
4038
builder.addCommonTServerFlag("TEST_ysql_yb_enable_ddl_savepoint_support", "true");
4139
builder.addMasterFlag("ysql_yb_ddl_transaction_block_enabled", "true");
42-
builder.addMasterFlag("enable_object_locking_for_table_locks", "true");
4340
builder.addMasterFlag("TEST_ysql_yb_enable_ddl_savepoint_support", "true");
4441
builder.addMasterFlag("vmodule", "catalog_manager=3,ysql_ddl_handler=4");
45-
builder.addMasterFlag("allowed_preview_flags_csv",
46-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
4742
}
4843

4944
@Test

java/yb-pgsql/src/test/java/org/yb/pgsql/TestDdlTransactionBlocks.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ protected void customizeMiniClusterBuilder(MiniYBClusterBuilder builder) {
3434
builder.enablePgTransactions(true);
3535
builder.addCommonTServerFlag("ysql_log_statement", "all");
3636
builder.addCommonTServerFlag("ysql_yb_ddl_transaction_block_enabled", "true");
37-
builder.addCommonTServerFlag("allowed_preview_flags_csv",
38-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
3937
builder.addCommonTServerFlag("enable_object_locking_for_table_locks", "true");
4038
}
4139

java/yb-pgsql/src/test/java/org/yb/pgsql/TestDropTableWithConcurrentTxn.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ protected Map<String, String> getTServerFlags() {
5252
// TODO(29141): Fix the test with txn ddl and enable.
5353
flagMap.put("ysql_yb_ddl_transaction_block_enabled", "false");
5454
flagMap.put("enable_object_locking_for_table_locks", "false");
55-
flagMap.put("allowed_preview_flags_csv",
56-
"ysql_yb_ddl_transaction_block_enabled,enable_object_locking_for_table_locks");
5755
return flagMap;
5856
}
5957

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgCacheConsistency.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ protected Map<String, String> getTServerFlags() {
4949
appendToYsqlPgConf(flags, "log_statement=all");
5050
// The test suite asserts for DML failing with catalog version mismatch when run
5151
// immediately after DDLs, which isn't true with object locking enabled.
52-
flags.put("allowed_preview_flags_csv",
53-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
5452
flags.put("enable_object_locking_for_table_locks", "false");
5553
// TODO(29142): Fix the test with txn ddl and reenable.
5654
flags.put("ysql_yb_ddl_transaction_block_enabled", "false");

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgDdlConcurrency.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ protected Map<String, String> getTServerFlags() {
4545
// TODO(#28745): Revisit this. Runs into a deadlock issue with table locks/txn-ddl enabled.
4646
flags.put("enable_object_locking_for_table_locks", "false");
4747
flags.put("ysql_yb_ddl_transaction_block_enabled", "false");
48-
flags.put("allowed_preview_flags_csv",
49-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
5048
return flags;
5149
}
5250

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgDdlFaultTolerance.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ protected Map<String, String> getTServerFlags() {
4242
// The test looks for a specific error message. So let's just disble the table locks here.
4343
flags.put("enable_object_locking_for_table_locks", "false");
4444
flags.put("ysql_yb_ddl_transaction_block_enabled", "false");
45-
flags.put("allowed_preview_flags_csv",
46-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
4745
return flags;
4846
}
4947

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgParallelReadIsolation.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ public class TestPgParallelReadIsolation extends BasePgSQLTest {
3232
protected Map<String, String> getTServerFlags() {
3333
Map<String, String> flagMap = super.getTServerFlags();
3434
flagMap.put("yb_enable_read_committed_isolation", "true");
35-
flagMap.put("allowed_preview_flags_csv",
36-
"enable_object_locking_for_table_locks,ysql_yb_ddl_transaction_block_enabled");
3735
flagMap.put("enable_object_locking_for_table_locks", "true");
3836
flagMap.put("ysql_yb_ddl_transaction_block_enabled", "true");
3937
return flagMap;

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgPushdownEfficiency.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ protected Map<String, String> getTServerFlags() {
2222
// table locks.
2323
flagMap.put("ysql_yb_ddl_transaction_block_enabled", "true");
2424
flagMap.put("enable_object_locking_for_table_locks", "false");
25-
flagMap.put("allowed_preview_flags_csv",
26-
"ysql_yb_ddl_transaction_block_enabled,enable_object_locking_for_table_locks");
2725
return flagMap;
2826
}
2927

0 commit comments

Comments
 (0)