Skip to content

Commit 5987b8e

Browse files
committed
[PLAT-17842]: Ensure runtime config for exsting Performance Advisor and new Perf Advisor are separate
Summary: This diff caused regression D44311 Performance Advisor under metrics tab was no longer available This happened because the previous diff consolidated both old and new perf advisor under same runtime config This cannot be done and they need to have separate flag Test Plan: Please refer to screenshot {F363408} Reviewers: jmak, kkannan Reviewed By: jmak Differential Revision: https://phorge.dev.yugabyte.com/D44687
1 parent 0e51069 commit 5987b8e

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

managed/ui/src/components/queries/QueriesViewer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const QueriesViewer = (props) => {
1414
<Tab eventKey="slow-queries" title="Slow Queries" key="slow-queries">
1515
<SlowQueries />
1616
</Tab>
17-
{props.isPerfAdvisorEnabled && (
17+
{props.isPerfAdvisorUIEnabled && (
1818
<Tab
1919
eventKey="perf-advisor"
2020
title="Performance Advisor"

managed/ui/src/components/universes/UniverseDetail/UniverseDetail.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,12 @@ class UniverseDetail extends Component {
468468
runtimeConfigs?.data?.configEntries?.find((c) => c.key === VM_PATCHING_RUNTIME_CONFIG)
469469
?.value === 'true';
470470

471-
const isPerfAdvisorEnabled =
471+
const isPerfAdvisorUIEnabled =
472+
runtimeConfigs?.data?.configEntries?.find(
473+
(config) => config.key === RuntimeConfigKey.PERFORMANCE_ADVISOR_UI_FEATURE_FLAG
474+
)?.value === 'true';
475+
476+
const isPerfAdvisorServiceEnabled =
472477
runtimeConfigs?.data?.configEntries?.find(
473478
(c) => c.key === RuntimeConfigKey.ENABLE_TROUBLESHOOTING
474479
)?.value === 'true';
@@ -694,7 +699,7 @@ class UniverseDetail extends Component {
694699
onExit={this.stripQueryParams}
695700
disabled={isDisabled(currentCustomer.data.features, 'universes.details.queries')}
696701
>
697-
<QueriesViewer isPerfAdvisorEnabled={isPerfAdvisorEnabled} />
702+
<QueriesViewer isPerfAdvisorUIEnabled={isPerfAdvisorUIEnabled} />
698703
</Tab.Pane>
699704
),
700705
isNotHidden(currentCustomer.data.features, 'universes.details.recovery') && isDrEnabled && (
@@ -744,7 +749,7 @@ class UniverseDetail extends Component {
744749
</Tab.Pane>
745750
),
746751
isNotHidden(currentCustomer.data.features, 'universes.details.perfAdvisor') &&
747-
isPerfAdvisorEnabled && (
752+
isPerfAdvisorServiceEnabled && (
748753
<Tab.Pane
749754
eventKey={'perfAdvisor'}
750755
tabtitle="Perf Advisor"
@@ -1556,7 +1561,7 @@ class UniverseDetail extends Component {
15561561
</YBMenuItem>
15571562
</RbacValidator>
15581563
)}
1559-
{!universePaused && isPerfAdvisorEnabled && (
1564+
{!universePaused && isPerfAdvisorServiceEnabled && (
15601565
<RbacValidator
15611566
isControl
15621567
accessRequiredOn={{

0 commit comments

Comments
 (0)