[yugabyte#26695] OpenDocDB: Add BSON and BID libraries and build DocumentDB

Summary:
Aging BSON and BID libraries to cmake and including the DocumentDB extension in the build. The extension is not available in aarch64 since the BID library is not available in this build type. This is an upstream restriction.

Fixes yugabyte#26695
Jira: DB-16070

Test Plan: Jenkins

Reviewers: esheng, asrivastava, #db-approvers, slingam

Reviewed By: asrivastava, #db-approvers, slingam

Subscribers: svc_phabricator, yql, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D43114

Author: hari90

CMakeLists.txt

@@ -298,6 +298,11 @@ else()
   message("CMake will not export the compilation database")
 endif()
 
+if(NOT "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "aarch64")
+  set(YB_ENABLE_YSQL_DOCUMENTDB_EXT TRUE)
+  ADD_CXX_FLAGS("-DYB_ENABLE_YSQL_DOCUMENTDB_EXT")
+endif()
+
 # -------------------------------------------------------------------------------------------------
 # Build type (debug, release, fastdebug, etc.)
 # -------------------------------------------------------------------------------------------------

cmake_modules/FindBid.cmake

@@ -0,0 +1,27 @@
+# Copyright (c) YugabyteDB, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+# in compliance with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed under the License
+# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+# or implied. See the License for the specific language governing permissions and limitations
+# under the License.
+#
+
+find_path(BID_INCLUDE_ROOT_DIR bid
+  # make sure we don't accidentally pick up a different version
+  NO_CMAKE_SYSTEM_PATH
+  NO_SYSTEM_ENVIRONMENT_PATH)
+set(BID_INCLUDE_DIR "${BID_INCLUDE_ROOT_DIR}/bid")
+find_library(BID_STATIC_LIB libbid.a
+  NO_CMAKE_SYSTEM_PATH
+  NO_SYSTEM_ENVIRONMENT_PATH)
+
+message(WARNING "BID_INCLUDE_DIR: ${BID_INCLUDE_DIR}")
+
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(BID REQUIRED_VARS
+  BID_STATIC_LIB BID_INCLUDE_DIR)

cmake_modules/FindBson.cmake

@@ -0,0 +1,25 @@
+# Copyright (c) YugabyteDB, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+# in compliance with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed under the License
+# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+# or implied. See the License for the specific language governing permissions and limitations
+# under the License.
+#
+
+find_path(BSON_INCLUDE_ROOT_DIR libbson-1.0
+  # make sure we don't accidentally pick up a different version
+  NO_CMAKE_SYSTEM_PATH
+  NO_SYSTEM_ENVIRONMENT_PATH)
+set(BSON_INCLUDE_DIR "${BSON_INCLUDE_ROOT_DIR}/libbson-1.0")
+find_library(BSON_STATIC_LIB libbson-static-1.0.a
+  NO_CMAKE_SYSTEM_PATH
+  NO_SYSTEM_ENVIRONMENT_PATH)
+
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(BSON REQUIRED_VARS
+  BSON_STATIC_LIB BSON_INCLUDE_DIR)

cmake_modules/YugabyteFindThirdParty.cmake

@@ -410,4 +410,19 @@ macro(yb_find_third_party_dependencies)
   ADD_THIRDPARTY_LIB(clockbound
     STATIC_LIB ${CLOCKBOUND_STATIC_LIB}
     INCLUDE_DIRS ${CLOCKBOUND_INCLUDE_DIR})
+
+  ## Bson
+  find_package(Bson REQUIRED)
+  include_directories(SYSTEM ${BSON_INCLUDE_DIR})
+  ADD_THIRDPARTY_LIB(bson
+    STATIC_LIB "${BSON_STATIC_LIB}")
+
+  ## Bid
+  if(NOT "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "aarch64")
+    find_package(Bid REQUIRED)
+    include_directories(SYSTEM ${BID_INCLUDE_DIR})
+    ADD_THIRDPARTY_LIB(bid
+      STATIC_LIB "${BID_STATIC_LIB}")
+  endif()
+
 endmacro()

src/postgres/third-party-extensions/Makefile

@@ -12,6 +12,10 @@ DIRS = \
 	wal2json \
 	pgtap \
 
+ifeq ($(YB_ENABLE_YSQL_DOCUMENTDB_EXT),TRUE)
+	documentdb
+endif
+
 BUILDDIRS = $(DIRS:%=build-%)
 INSTALLDIRS = $(DIRS:%=install-%)
 CLEANDIRS = $(DIRS:%=clean-%)

src/postgres/third-party-extensions/documentdb/Makefile.cflags

@@ -1,7 +1,8 @@
 
 
-LIBBSON := $(shell pkg-config --cflags libbson-static-1.0)
-INTEL_DECIMAL_MATH_LIB = $(shell pkg-config --cflags intelmathlib)
+# YB: Bson and BID are linked through YugabyteDB thirdparty
+# LIBBSON := -pthread -DBSON_STATIC -isystem /usr/local/include/libbson-1.0
+# INTEL_DECIMAL_MATH_LIB = $(shell pkg-config --cflags intelmathlib)
 PCRE2_LIB = $(shell pkg-config --cflags libpcre2-8)
 
 DOCUMENTDB_CORE_DIR = $(OSS_SRC_DIR)/pg_documentdb_core
@@ -13,7 +14,7 @@ DOCUMENTDB_INC_DIR = $(DOCUMENTDB_DIR)/include
 DOCUMENTDB_DISTRIBUTED_INC_DIR = $(DOCUMENTDB_DISTRIBUTED_DIR)/include
 
 
-PG_CPPFLAGS = $(LIBBSON) -I$(libpq_srcdir) $(INTEL_DECIMAL_MATH_LIB) $(PCRE2_LIB) -Isrc -Iinclude -Ibuild/include/
+PG_CPPFLAGS = -I$(libpq_srcdir) $(PCRE2_LIB) -Isrc -Iinclude -Ibuild/include/
 PG_LDFLAGS = $(shell pkg-config --static --libs --cflags libbson-static-1.0) $(shell pkg-config --static --libs --cflags intelmathlib) $(shell pkg-config --static --libs --cflags libpcre2-8) -L/usr/lib
 PG_LDFLAGS += -Wl,-rpath=$(shell $(PG_CONFIG) --pkglibdir)
 
@@ -36,9 +37,9 @@ PG_LDFLAGS += -l:pg_documentdb_distributed.so -L $(DOCUMENTDB_DISTRIBUTED_DIR)
 endif
 
 ifeq ($(CC),gcc)
-    PG_CFLAGS = -std=gnu99 -Wall -Wextra -Werror -Wno-declaration-after-statement -Wno-unused-parameter -Wno-implicit-fallthrough $(LIBBSON) $(INTEL_DECIMAL_MATH_LIB) $(PCRE2_LIB)
+    PG_CFLAGS = -std=gnu99 -Wall -Wextra -Werror -Wno-declaration-after-statement -Wno-unused-parameter -Wno-implicit-fallthrough $(PCRE2_LIB)
 else
-    PG_CFLAGS = -std=gnu99 -Wall -Wextra -Werror -Wno-declaration-after-statement -Wno-unused-parameter -Wno-implicit-fallthrough $(LIBBSON) $(INTEL_DECIMAL_MATH_LIB) $(PCRE2_LIB)
+    PG_CFLAGS = -std=gnu99 -Wall -Wextra -Werror -Wno-declaration-after-statement -Wno-unused-parameter -Wno-implicit-fallthrough $(PCRE2_LIB)
 endif
 
 ifneq ($(SKIP_API_SCHEMA),yes)