Skip to content

Commit 28bb53b

Browse files
authored
Remove TODO(SL) occurrences (#30)
* created issue #28 * add a warning in the console. No need to do more * remove comment
1 parent aa338f8 commit 28bb53b

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

packages/components/src/lib/tableProvider.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export function parquetDataFrame(from: AsyncBufferFromUrl, metadata: FileMetaDat
1414
const sortCache = new Map<string, Promise<number[]>>()
1515
const data = new Array<ResolvableRow>(Number(metadata.num_rows))
1616
/// ^ warning: the type is a lie at that point, because all rows are undefined for now
17-
/// TODO(SL): improve the type safety
1817
const groups = new Array(metadata.row_groups.length).fill(false)
1918
let groupStart = 0
2019
const groupEnds = metadata.row_groups.map(group => groupStart += Number(group.num_rows))

packages/components/src/workers/parquetWorkerClient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ function getWorker() {
2727
worker.onmessage = ({ data }: { data: ParquetMessage | SortParquetMessage }) => {
2828
const pendingQueryAgent = pending.get(data.queryId)
2929
if (!pendingQueryAgent) {
30-
throw new Error(
30+
console.warn(
3131
`Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`,
3232
)
33-
// TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps.
33+
return
3434
}
3535
if (pendingQueryAgent.kind === 'query') {
3636
const { resolve, reject, onChunk } = pendingQueryAgent

src/app.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ import ReactDOM from 'react-dom/client'
55
const app = document.getElementById('app')
66
if (!app) throw new Error('missing app element')
77

8-
// @ts-expect-error TODO: fix react createRoot type
9-
const root = ReactDOM.createRoot(document.getElementById('app'))
8+
const root = ReactDOM.createRoot(app)
109
root.render(React.createElement(App))

0 commit comments

Comments
 (0)