group shared eslint rules (#41)

* group shared eslint rules

* add line

Author: severo

apps/cli/eslint.config.js

@@ -1,6 +1,7 @@
 import javascript from '@eslint/js'
 import globals from 'globals'
 import typescript from 'typescript-eslint'
+import { sharedJsRules } from '../../shared.eslint.config.js'
 
 export default [
   {
@@ -21,41 +22,7 @@ export default [
     rules: {
       ...javascript.configs.recommended.rules,
       ...typescript.configs.recommended.rules,
-      'arrow-spacing': 'error',
-      camelcase: 'off',
-      'comma-spacing': 'error',
-      'comma-dangle': ['error', 'always-multiline'],
-      'eol-last': 'error',
-      eqeqeq: 'error',
-      'func-style': ['error', 'declaration'],
-      indent: ['error', 2],
-      'no-constant-condition': 'off',
-      'no-extra-parens': 'error',
-      'no-multi-spaces': 'error',
-      'no-trailing-spaces': 'error',
-      'no-unused-vars': 'warn',
-      'no-useless-concat': 'error',
-      'no-useless-rename': 'error',
-      'no-useless-return': 'error',
-      'no-var': 'error',
-      'object-curly-spacing': ['error', 'always'],
-      'prefer-const': 'warn',
-      'prefer-destructuring': ['warn', {
-        object: true,
-        array: false,
-      }],
-      'prefer-promise-reject-errors': 'error',
-      quotes: ['error', 'single'],
-      'require-await': 'warn',
-      semi: ['error', 'never'],
-
-      'sort-imports': ['error', {
-        ignoreDeclarationSort: true,
-        ignoreMemberSort: false,
-        memberSyntaxSortOrder: ['none', 'all', 'multiple', 'single'],
-      }],
-
-      'space-infix-ops': 'error',
+      ...sharedJsRules,
     },
   },
 ]

apps/hightable-demo/eslint.config.js

@@ -4,6 +4,7 @@ import reactHooks from 'eslint-plugin-react-hooks'
 import reactRefresh from 'eslint-plugin-react-refresh'
 import globals from 'globals'
 import tseslint from 'typescript-eslint'
+import { sharedJsRules, sharedTsRules } from '../../shared.eslint.config.js'
 
 export default tseslint.config(
   { ignores: ['dist'] },
@@ -26,15 +27,17 @@ export default tseslint.config(
       'react-refresh': reactRefresh,
     },
     rules: {
+      ...react.configs.recommended.rules,
+      ...react.configs['jsx-runtime'].rules,
       ...reactHooks.configs.recommended.rules,
       'react-refresh/only-export-components': [
         'warn',
         { allowConstantExport: true },
       ],
-      ...react.configs.recommended.rules,
-      ...react.configs['jsx-runtime'].rules,
-
-      '@typescript-eslint/restrict-template-expressions': 'off',
+      ...js.configs.recommended.rules,
+      ...tseslint.configs.recommended.rules,
+      ...sharedJsRules,
+      ...sharedTsRules,
     },
   },
 )

apps/hightable-demo/src/data.tsx

@@ -5,9 +5,9 @@ function lorem(rand: number, length: number): string {
   const str = Array.from({ length }, (_, i) => words[Math.floor(i + rand * 8) % 8]).join(' ')
   return str[0].toUpperCase() + str.slice(1)
 }
-  
+
 function delay<T>(value: T, ms: number): Promise<T> {
-  return new Promise(resolve => setTimeout(() => { resolve(value);}, ms))
+  return new Promise(resolve => setTimeout(() => { resolve(value) }, ms))
 }
 
 const header = ['ID', 'Name', 'Age', 'UUID', 'Text', 'JSON']

package.json

@@ -3,6 +3,7 @@
   "private": true,
   "description": "Hyperparam apps and packages",
   "license": "MIT",
+  "type": "module",
   "workspaces": [
     "apps/cli",
     "apps/hightable-demo",

packages/components/eslint.config.js

@@ -4,6 +4,7 @@ import reactHooks from 'eslint-plugin-react-hooks'
 import reactRefresh from 'eslint-plugin-react-refresh'
 import globals from 'globals'
 import tseslint from 'typescript-eslint'
+import { sharedJsRules, sharedTsRules } from '../../shared.eslint.config.js'
 
 export default tseslint.config(
   { ignores: ['coverage/', 'dist/', 'es/'] },
@@ -32,47 +33,10 @@ export default tseslint.config(
         'warn',
         { allowConstantExport: true },
       ],
-      /// ^ from vite default configuration
       ...js.configs.recommended.rules,
       ...tseslint.configs.recommended.rules,
-      'arrow-spacing': 'error',
-      camelcase: 'off',
-      'comma-spacing': 'error',
-      'comma-dangle': ['error', 'always-multiline'],
-      'eol-last': 'error',
-      eqeqeq: 'error',
-      'func-style': ['error', 'declaration'],
-      indent: ['error', 2],
-      'no-constant-condition': 'off',
-      'no-extra-parens': 'error',
-      'no-multi-spaces': 'error',
-      'no-trailing-spaces': 'error',
-      'no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-vars': 'warn',
-      'no-useless-concat': 'error',
-      'no-useless-rename': 'error',
-      'no-useless-return': 'error',
-      'no-var': 'error',
-      'object-curly-spacing': ['error', 'always'],
-      'prefer-const': 'warn',
-      'prefer-destructuring': ['warn', {
-        object: true,
-        array: false,
-      }],
-      'prefer-promise-reject-errors': 'error',
-      quotes: ['error', 'single'],
-      'require-await': 'warn',
-      semi: ['error', 'never'],
-
-      'sort-imports': ['error', {
-        ignoreDeclarationSort: true,
-        ignoreMemberSort: false,
-        memberSyntaxSortOrder: ['none', 'all', 'multiple', 'single'],
-      }],
-
-      'space-infix-ops': 'error',
-
-      '@typescript-eslint/restrict-template-expressions': 'off',
+      ...sharedJsRules,
+      ...sharedTsRules,
     },
   },
   {

shared.eslint.config.js

@@ -0,0 +1,42 @@
+export const sharedJsRules = {
+  'arrow-spacing': 'error',
+  camelcase: 'off',
+  'comma-spacing': 'error',
+  'comma-dangle': ['error', 'always-multiline'],
+  'eol-last': 'error',
+  eqeqeq: 'error',
+  'func-style': ['error', 'declaration'],
+  indent: ['error', 2],
+  'no-constant-condition': 'off',
+  'no-extra-parens': 'error',
+  'no-multi-spaces': 'error',
+  'no-trailing-spaces': 'error',
+  'no-unused-vars': 'off',
+  'no-useless-concat': 'error',
+  'no-useless-rename': 'error',
+  'no-useless-return': 'error',
+  'no-var': 'error',
+  'object-curly-spacing': ['error', 'always'],
+  'prefer-const': 'warn',
+  'prefer-destructuring': ['warn', {
+    object: true,
+    array: false,
+  }],
+  'prefer-promise-reject-errors': 'error',
+  quotes: ['error', 'single'],
+  'require-await': 'warn',
+  semi: ['error', 'never'],
+
+  'sort-imports': ['error', {
+    ignoreDeclarationSort: true,
+    ignoreMemberSort: false,
+    memberSyntaxSortOrder: ['none', 'all', 'multiple', 'single'],
+  }],
+
+  'space-infix-ops': 'error',
+}
+
+export const sharedTsRules = {
+  '@typescript-eslint/restrict-template-expressions': 'off',
+  '@typescript-eslint/no-unused-vars': 'warn',
+}