Commit 876c717
authored
Xet upload: backtrack when dedup info is received (#1708)
Fix #1703
cc @assafvayner for viz, cc @Kakulukian too
## Note
Only backtrack since the end of the last file, and only in the current
xorb.
It means that we maybe lose ~2MB on average at the end of a xorb - only
if we filled the first 60MB of the xorb with new data
## Improvement
Running `pnpm --filter hub bench`:
```console
=== BENCHMARK RESULTS ===
File Statistics:
================
📄 64-8bits.tflite:
Size: 119.36 MB
Deduplication: 99.90%
📄 64-fp16.tflite:
Size: 236.77 MB
Deduplication: 100.00%
=== SUMMARY ===
Total files: 2
Total size: 356.13 MB
Total xorbs: 1
Total shards: 1
Total xorb bytes: 119 926 bytes
Total shard bytes: 1 400 bytes
Average deduplication: 99.95%
```
we bump the second file from 83% to 100% dedup1 parent 57d7cf7 commit 876c717
File tree
4 files changed
+366
-129
lines changed- packages/hub
- scripts
- src/utils
4 files changed
+366
-129
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
| |||
68 | 76 | | |
69 | 77 | | |
70 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
71 | 88 | | |
72 | 89 | | |
73 | 90 | | |
| |||
92 | 109 | | |
93 | 110 | | |
94 | 111 | | |
95 | | - | |
| 112 | + | |
96 | 113 | | |
97 | 114 | | |
98 | 115 | | |
| |||
111 | 128 | | |
112 | 129 | | |
113 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
114 | 136 | | |
115 | 137 | | |
116 | 138 | | |
| |||
123 | 145 | | |
124 | 146 | | |
125 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
126 | 153 | | |
127 | 154 | | |
128 | 155 | | |
| |||
158 | 185 | | |
159 | 186 | | |
160 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
161 | 193 | | |
162 | 194 | | |
163 | 195 | | |
| |||
189 | 221 | | |
190 | 222 | | |
191 | 223 | | |
192 | | - | |
| 224 | + | |
193 | 225 | | |
194 | 226 | | |
195 | 227 | | |
| |||
290 | 322 | | |
291 | 323 | | |
292 | 324 | | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
293 | 338 | | |
294 | 339 | | |
295 | 340 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
47 | 50 | | |
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
54 | | - | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| |||
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
70 | 77 | | |
0 commit comments