Skip to content

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Oct 30, 2025

What does this PR do?

Fix bug in loading blocks with custom block kwargs. Current implementation throws an error because kwargs.pop changes the size of the input dict that we're looping over.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 DN6 requested a review from yiyixuxu October 30, 2025 09:47
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DN6 DN6 merged commit df8dd77 into main Oct 30, 2025
16 of 18 checks passed
@yiyixuxu yiyixuxu deleted the modular-block-kwargs branch October 30, 2025 21:33
@DN6 DN6 added the roadmap Add to current release roadmap label Nov 10, 2025
@DN6 DN6 moved this from In Progress to Done in Diffusers Roadmap 0.36 Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roadmap Add to current release roadmap

Projects

Development

Successfully merging this pull request may close these issues.

4 participants