-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[Modular] Add single file support to Modular #12383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@bot /style |
|
Style bot fixed some files and pushed the changes. |
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
@yiyixuxu Since there are some public models using modular thought it would be better to deprecate |
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! change looks good to me
I will run more slow tests later, but good to merge as long as you test out the public repo (krea) and make sure it works there
What does this PR do?
This PR
Adds support for single file loading in ComponentSpec
Renames the
repoargument topretrained_model_name_or_path. IMO this makes more sense if the same argument supports both filepath and repo_ids. Saw that there was a comment in there considering this chase, so I added it here. Alternatively, we can introduce a filename argument, but I this is cleaner.Snippet to test
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.