Cannot remove newlines between tags even with options

[TrofinSorin]

Minimal HTML example

<h1>1</h1>
<h1>2</h1>
<h1>3</h1>

Options

{
        wordwrap: false,
        preserveNewlines: false,
        selectors: [
          { selector: 'p', options: { leadingLineBreaks: 0, trailingLineBreaks: 0 } },
          { selector: 'h1', options: { leadingLineBreaks: 0, trailingLineBreaks: 0 } },
          { selector: 'h2', options: { leadingLineBreaks: 0, trailingLineBreaks: 0 } },
          { selector: 'h3', options: { leadingLineBreaks: 0, trailingLineBreaks: 0 } },
        ]
      }

Observed output
Before the selector options there were 2 newlines. But with those options it's reduced to one newline.

1
(newline here)
2
(newline here)
3

Expected output

I want this output without newlines

1
2
3

The same as inside wysiwig, without newlines but H1

Version information

• html-to-text: 9.0.5
• node: 18.19.0

---

[KillyMXI]

These options will work:

{
  selectors: [
    { selector: 'h1', options: { leadingLineBreaks: 1, trailingLineBreaks: 1 } },
  ]
}

What happens with zero:
The condition 0 || 2 equates to the default value of 2.

Notice that this counts line breaks, not empty lines.
Zero line breaks would mean "continue on the same line" which doesn't make sense for block level tags.

I agree that this logic might be somewhat less intuitive though. It should probably be clamped to the closest valid value and sent a warning when misused...

[cherrykkk]

These options will work:

{
selectors: [
{ selector: 'h1', options: { leadingLineBreaks: 1, trailingLineBreaks: 1 } },
]
}
What happens with zero: The condition 0 || 2 equates to the default value of 2.

Notice that this counts line breaks, not empty lines. Zero line breaks would mean "continue on the same line" which doesn't make sense for block level tags.

I agree that this logic might be somewhat less intuitive though. It should probably be clamped to the closest valid value and sent a warning when misused...

How about use "{ leadingLineBreaks: formatOptions.leadingLineBreaks ?? 2 }" to replace the current "{ leadingLineBreaks: formatOptions.leadingLineBreaks || 2 }"?

Maybe someone really want to continue on the same line, or maybe someone is debugging on how to change the number of line breaks, just like me ……

[KillyMXI]

Maybe someone really want to continue on the same line

Gluing new block to the previous one is not really possible. And in plain text output context I see little sense trying to invent it.

Normal HTML output can have inline-blocks, but that's not the same as mixing blocks in inline flow. And implementing inline-blocks in the constraints of plain-text output also doesn't make much sense.

Once I change || 2 to ?? 2, I will have to think about explicit way to deal with zero or it will fail in an uglier way.
I may make it more informative once I get to it, as I mentioned previously.