Remove the dependency on collections package #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collections package we are using seems to be an obsolete pollyfill, so depending on how you use this package, there is a problem that pollutes the global scope and breaks the runtime. For example, there seems to be a bug in the Object.values() function of collections. These modern ECMAScript features are already available as standard in many browsers and Node.js, so it is better to use the native standard features rather than fixing collections package. Instead of collections/fast-map, it will change it to use native JavaScript Maps. These work faster in current browsers and Node.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
collectionspackage we are using seems to be an obsolete pollyfill, so depending on how you use this package, there is a problem that pollutes the global scope and breaks the runtime. For example, there seems to bea bug in the
Object.values()function of collections. These modern ECMAScript features are already available as standard in many browsers and Node.js, so it is better to use the native standard features rather than fixingcollectionspackage.Instead of
collections/fast-map, it will change it to use native JavaScript Maps. These work faster in current browsers and Node.js.