-
Notifications
You must be signed in to change notification settings - Fork 2
Join room #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maayamohan
wants to merge
38
commits into
main
Choose a base branch
from
join-room
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Join room #27
Changes from 23 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e9f254b
docs: add pull request template (#10)adds a PR template for more stru…
maayamohan d0623c1
feat: update index.html and PeerConnection.js
maayamohan 25985a8
feat: Implement multi-user streaming changed server.js accordingly
maayamohan b1c2493
frontend
SolarPhoenix13 ea90d7a
refactor: Moved client side script code to new file
maayamohan adbc6cb
feat: Display room code and code input field
maayamohan e640b91
feat: Implemented room logic
maayamohan c16e947
refactor: Moved all html scripts to client.js
maayamohan 44335ff
chore: cleaning up client.js
maayamohan ecc2391
feat: add auto bitrate (#21)
Delta18-Git 0a2c007
chore: update index.html to previous state
Delta18-Git 8fd826d
chore: remove unnecessary files
Delta18-Git bd8aa0b
chore: Added navigation.js to handle all page navigations
maayamohan 6f18056
refactor: Moved host relevant code to host.js
maayamohan 73a6c43
fix: Fixed enter room button display condition for join
maayamohan cc934ad
refactor: Moved join relevant code to join.js
maayamohan cd68ec4
fix: Made fixes in host.js
maayamohan 57db5c1
Update index.html
SolarPhoenix13 f6803d3
Update index.html
SolarPhoenix13 8c07ed3
fix: Fixed script source file name in page2.html
maayamohan bd5b007
Merge branch 'join-room' of github.com:homebrew-ec-foss/JamSesh into …
maayamohan 8028359
refactor: Added comments for the code blocks
maayamohan 0a6694c
refactor: Refactor in host.js
maayamohan 4bc47e9
fix: Removed reinitialisation of ws in navigation.js
maayamohan 0b6e44d
feat: Sending start-call message from host.js
maayamohan e975302
feat: Added room-code validation from the server
vanshsoma 5a362d9
fix: Disable start call button till host starts call
maayamohan 3ee626b
Merge branch 'join-room' of https://github.com/homebrew-ec-foss/JamSe…
vanshsoma ca86979
feat: Added working room logic for multiple rooms
vanshsoma c6b4ba1
fix: Wrong api end point
vanshsoma 00f3e05
feat: Added more user friendly UI-UX
vanshsoma 2e4ee8e
fix: Made continous UI and fixed volume issues
vanshsoma 9d0555d
fix: Bug in websocket link
vanshsoma 547b544
fix: Uptime ping
vanshsoma f994303
feat: integrate timesync for sync playback (#28)
Gowda-Arjun 9c24a33
fix: Installed dependencies
vanshsoma 0f5f316
fix: clients not receiving stream
Gowda-Arjun c0c226f
fix: rechecks latency every 5s
Gowda-Arjun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| # dependencies | ||
| .DS_Store | ||
| node_modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>Host a Jam</title> | ||
| <link href="https://fonts.googleapis.com/css2?family=Fjalla+One&display=swap" rel="stylesheet"> | ||
| <style> | ||
| body { | ||
| background-color: #152238; | ||
| color: white; | ||
| font-family: 'Fjalla One', sans-serif; | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| height: 100vh; | ||
| } | ||
|
|
||
| h1 { | ||
| font-size: 60px; | ||
| margin-bottom: 40px; | ||
| } | ||
|
|
||
| button { | ||
| padding: 14px 28px; | ||
| font-size: 22px; | ||
| border: none; | ||
| border-radius: 10px; | ||
| background-color: #0F52BA; | ||
| color: white; | ||
| cursor: pointer; | ||
| margin-top: 20px; | ||
| transition: background-color 0.3s; | ||
| } | ||
|
|
||
| button:hover { | ||
| background-color: #0c47a1; | ||
| } | ||
|
|
||
| #jamCodeDisplay { | ||
| font-size: 28px; | ||
| margin-top: 20px; | ||
| color: #00ffff; | ||
| } | ||
|
|
||
| #enterRoomHostBtn { | ||
| display: none; | ||
| } | ||
|
|
||
| a { | ||
| position: absolute; | ||
| top: 20px; | ||
| left: 20px; | ||
| color: #00ffff; | ||
| text-decoration: none; | ||
| font-size: 18px; | ||
| } | ||
| </style> | ||
| <script src="js/navigation.js" defer></script> | ||
| </head> | ||
| <body> | ||
|
|
||
| <a href="index.html">← Back to Home</a> | ||
| <h1>Host a Jam</h1> | ||
| <button id="generateCodeBtn">Generate Jam Code</button> | ||
| <div id="jamCodeDisplay"></div> | ||
|
|
||
| <!-- New Button --> | ||
| <button id="enterRoomHostBtn">Enter the Room</button> | ||
|
|
||
| </body> | ||
| </html> | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to move the CSS to a separate file which is imported as there is a lot of shared loc in these webpages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment applies for all other pages.