Merge pull request #118 from hjacobs/pod-name-undefined

hjacobs · web-flow · commit c9190c5d55b9 · 2017-01-24T17:34:21.000+01:00
#103 assume empty pod name if undefined
diff --git a/app/src/pod.js b/app/src/pod.js
@@ -6,7 +6,9 @@ import {BRIGHTNESS_FILTER} from './filters.js'
 const ALL_PODS = {}
 
 const sortByName = (a, b) => {
-    return a.name.localeCompare(b.name)
+    // https://github.com/hjacobs/kube-ops-view/issues/103
+    // *.name might be undefined
+    return (a.name || '').localeCompare(b.name || '')
 }
 
 const sortByAge = (a, b) => {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,9 @@ import {BRIGHTNESS_FILTER} from './filters.js'`
`6`	`6`	`const ALL_PODS = {}`
`7`	`7`
`8`	`8`	`const sortByName = (a, b) => {`
`9`		`- return a.name.localeCompare(b.name)`
	`9`	`+ // https://github.com/hjacobs/kube-ops-view/issues/103`
	`10`	`+ // *.name might be undefined`
	`11`	`+ return (a.name \|\| '').localeCompare(b.name \|\| '')`
`10`	`12`	`}`
`11`	`13`
`12`	`14`	`const sortByAge = (a, b) => {`