Skip to content
This repository was archived by the owner on Oct 3, 2020. It is now read-only.

Commit 1181f36

Browse files
authored
Merge pull request #130 from hjacobs/handle-empty-time-string
#129 handle pods in strange error state
2 parents d4fdf1a + 5bdef77 commit 1181f36

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

kube_ops_view/kubernetes.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,12 @@ def query_kubernetes_cluster(cluster):
8484
if obj['phase'] in ('Succeeded', 'Failed'):
8585
last_termination_time = 0
8686
for container in obj['containers']:
87-
termination_time = container.get('state', {}).get('terminated', {}).get('finishedAt', '')
88-
termination_time = parse_time(termination_time)
89-
if termination_time > last_termination_time:
90-
last_termination_time = termination_time
91-
if last_termination_time < now - 3600:
87+
termination_time = container.get('state', {}).get('terminated', {}).get('finishedAt')
88+
if termination_time:
89+
termination_time = parse_time(termination_time)
90+
if termination_time > last_termination_time:
91+
last_termination_time = termination_time
92+
if last_termination_time and last_termination_time < now - 3600:
9293
# the job/pod finished more than an hour ago
9394
# => filter out
9495
continue

0 commit comments

Comments
 (0)