-
Notifications
You must be signed in to change notification settings - Fork 93
feat: nonce ordering with locks #4635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
konstantinabl
wants to merge
10
commits into
main
Choose a base branch
from
feat/nonce-ordering-with-locks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
f976f16 to
a36fcff
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #4635 +/- ##
==========================================
+ Coverage 95.48% 95.50% +0.02%
==========================================
Files 129 134 +5
Lines 20898 21484 +586
Branches 1777 1827 +50
==========================================
+ Hits 19954 20518 +564
- Misses 924 945 +21
- Partials 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
natanasow
approved these changes
Nov 28, 2025
simzzz
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the new experimental feature for nonce_ordering, which aims to reduce WRONG_NONCE errors due to requests being shuffled, because of asynchronous operations in the relay
Related issue(s)
Fixes #4591
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist