Fix infinite recursion in transformers plugin for self-referential schemas

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Author: Copilot

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/transformers-all-of/transformers.gen.ts

@@ -2,16 +2,10 @@
 
 import type { GetFooResponse } from './types.gen';
 
-const quxSchemaResponseTransformer = (data: any) => {
-    if (data.baz) {
-        data.baz = new Date(data.baz);
-    }
-    return data;
-};
-
-const bazSchemaResponseTransformer = (data: any) => {
-    data = quxSchemaResponseTransformer(data);
-    data.bar = new Date(data.bar);
+const fooSchemaResponseTransformer = (data: any) => {
+    data.foo = data.foo.map((item: any) => {
+        return barSchemaResponseTransformer(item);
+    });
     return data;
 };
 
@@ -22,10 +16,16 @@ const barSchemaResponseTransformer = (data: any) => {
     return data;
 };
 
-const fooSchemaResponseTransformer = (data: any) => {
-    data.foo = data.foo.map((item: any) => {
-        return barSchemaResponseTransformer(item);
-    });
+const bazSchemaResponseTransformer = (data: any) => {
+    data = quxSchemaResponseTransformer(data);
+    data.bar = new Date(data.bar);
+    return data;
+};
+
+const quxSchemaResponseTransformer = (data: any) => {
+    if (data.baz) {
+        data.baz = new Date(data.baz);
+    }
     return data;
 };
 

packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/transformers-all-of/transformers.gen.ts

@@ -2,16 +2,10 @@
 
 import type { GetFooResponse } from './types.gen';
 
-const quxSchemaResponseTransformer = (data: any) => {
-    if (data.baz) {
-        data.baz = new Date(data.baz);
-    }
-    return data;
-};
-
-const bazSchemaResponseTransformer = (data: any) => {
-    data = quxSchemaResponseTransformer(data);
-    data.bar = new Date(data.bar);
+const fooSchemaResponseTransformer = (data: any) => {
+    data.foo = data.foo.map((item: any) => {
+        return barSchemaResponseTransformer(item);
+    });
     return data;
 };
 
@@ -22,10 +16,16 @@ const barSchemaResponseTransformer = (data: any) => {
     return data;
 };
 
-const fooSchemaResponseTransformer = (data: any) => {
-    data.foo = data.foo.map((item: any) => {
-        return barSchemaResponseTransformer(item);
-    });
+const bazSchemaResponseTransformer = (data: any) => {
+    data = quxSchemaResponseTransformer(data);
+    data.bar = new Date(data.bar);
+    return data;
+};
+
+const quxSchemaResponseTransformer = (data: any) => {
+    if (data.baz) {
+        data.baz = new Date(data.baz);
+    }
     return data;
 };
 

packages/openapi-ts/src/plugins/@hey-api/transformers/plugin.ts

@@ -63,6 +63,19 @@ const processSchemaType = ({
     if (!plugin.getSymbol(selector)) {
       // TODO: remove
       // create each schema response transformer only once
+
+      // Register symbol early to prevent infinite recursion with self-referential schemas
+      const symbol = plugin.registerSymbol({
+        name: buildName({
+          config: {
+            case: 'camelCase',
+            name: '{{name}}SchemaResponseTransformer',
+          },
+          name: refToName(schema.$ref),
+        }),
+        selector,
+      });
+
       const refSchema = plugin.context.resolveIrRef<IR.SchemaObject>(
         schema.$ref,
       );
@@ -71,16 +84,6 @@ const processSchemaType = ({
         schema: refSchema,
       });
       if (nodes.length) {
-        const symbol = plugin.registerSymbol({
-          name: buildName({
-            config: {
-              case: 'camelCase',
-              name: '{{name}}SchemaResponseTransformer',
-            },
-            name: refToName(schema.$ref),
-          }),
-          selector,
-        });
         const node = tsc.constVariable({
           expression: tsc.arrowFunction({
             async: false,