JPA Delete By

Author: giaunv

jpa-hibernate-examples/jpa-hibernate-crud-deleting-entity/pom.xml

@@ -11,7 +11,7 @@
     <parent>
         <groupId>org.springframework.boot</groupId>
         <artifactId>spring-boot-starter-parent</artifactId>
-        <version>2.1.1.RELEASE</version>
+        <version>2.1.4.RELEASE</version>
     </parent>
 
     <properties>

jpa-hibernate-examples/jpa-hibernate-crud-deleting-entity/src/test/java/com/hellokoding/jpa/book/DeletingDataTest.java

@@ -1,56 +1,64 @@
 package com.hellokoding.jpa.book;
 
-import lombok.NoArgsConstructor;
-import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.test.annotation.DirtiesContext;
+import org.springframework.boot.test.autoconfigure.orm.jpa.TestEntityManager;
 import org.springframework.test.context.junit4.SpringRunner;
 
-import java.util.Optional;
-
-@NoArgsConstructor
+import static org.assertj.core.api.Assertions.assertThat;
 
 @RunWith(SpringRunner.class)
 @DataJpaTest
-@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD)
 public class DeletingDataTest {
+    @Autowired
+    private TestEntityManager testEntityManager;
+
     @Autowired
     private BookRepository bookRepository;
 
     @Autowired
     private CategoryRepository categoryRepository;
 
+    private int givenCategoryId;
+
     @Before
-    public void createTestData(){
-        categoryRepository.save(new Category("A", new Book("A1"), new Book("A2")));
+    public void setUp(){
+        // given
+        givenCategoryId = testEntityManager.persistAndFlush(new Category("A", new Book("A1"), new Book("A2"))).getId();
     }
 
     @Test
-    public void testDelete_whenJPQL_thenSuccess() {
-        bookRepository.deleteByCategoryId(1);
-        Assert.assertEquals(0, bookRepository.findByCategoryId(1).size());
+    public void whenDeleteByJPQL_thenSuccess() {
+        // when
+        bookRepository.deleteByCategoryId(givenCategoryId);
+
+        // then
+        assertThat(bookRepository.findByCategoryId(givenCategoryId)).hasSize(0);
     }
 
     @Test
-    public void testDelete_whenOrphanRemoval_thenSuccess() {
-        Category category = categoryRepository.findById(1).get();
+    public void whenDeleteByOrphanRemoval_thenSuccess() {
+        // when
+        Category category = categoryRepository.findById(givenCategoryId).get();
         Book book = category.getBooks().iterator().next();
         int bookId = book.getId();
         category.getBooks().remove(book);
         categoryRepository.flush();
 
-        Assert.assertEquals(Optional.empty(), bookRepository.findById(bookId));
+        // then
+        assertThat(bookRepository.findById(bookId)).isEmpty();
     }
 
     @Test
-    public void testDelete_whenCascadeAll_thenSuccess() {
-        Category category = categoryRepository.findById(1).get();
+    public void whenDeleteByCascadeType_thenSuccess() {
+        // when
+        Category category = categoryRepository.findById(givenCategoryId).get();
         categoryRepository.delete(category);
 
-        Assert.assertEquals(0, bookRepository.findByCategoryId(1).size());
+        // then
+        assertThat(bookRepository.findByCategoryId(givenCategoryId)).hasSize(0);
     }
 }