ai-assistant: Type fixing, upgrading dependencies #452
+3,997
−4,636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Was using the wrong props for some labels. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume
changed the title
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
It was missing the required generic typing of the config. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This code needs more fixing, but this is an improvement and we can continue it later... and have the type checker work for the rest of the code. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
… prop Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Also fix a ts issue. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume
force-pushed
the
ai-fixes
branch
3 times, most recently
from
9f289ad to
5251ef1
Compare
illume
changed the title
illume
changed the title
Also need to change tsconfig so that langchain can work, because it is no longer compatible with the other way of doing things. Signed-off-by: René Dudfield <renedudfield@microsoft.com> Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Also fix some issues related to the upgrade found with ts. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
skoeva
requested changes
Dec 5, 2025
Contributor
skoeva
left a comment
skoeva
left a comment
There was a problem hiding this comment.
thanks for all this work! left some comments
| if (method.toUpperCase() === 'PUT' && showUpdateConfirm) { | ||
| return ( | ||
| <ConfirmDialog | ||
| // @todo: open does exist on ConfirmDialog, but TS is not recognizing it. |
Contributor
There was a problem hiding this comment.
we could handle this type issue within src/headlamp-plugin.d.ts
/// <reference types="@kinvolk/headlamp-plugin" />
import type { DialogProps as MuiDialogProps } from '@mui/material/Dialog';
declare module '@kinvolk/headlamp-plugin/lib/CommonComponents' {
interface ConfirmDialogProps {
/** Forwarded to the underlying MUI dialog */
open: MuiDialogProps['open'];
}
}
ai-assistant/src/utils.tsx
Outdated
| export const getSettingsURL = () => `/settings/plugins/${encodeURIComponent(PLUGIN_NAME)}`; | ||
|
|
||
| export const pluginStore = new ConfigStore(PLUGIN_NAME); | ||
| export const pluginStore = new ConfigStore<{ isUIPanelOpen?: boolean }>(PLUGIN_NAME); |
Contributor
There was a problem hiding this comment.
this change gets overwritten by dadc8f7, maybe this commit can be dropped?
ai-assistant/src/textstream.tsx
Outdated
| import ContentRenderer from './ContentRenderer'; | ||
| import EditorDialog from './editordialog'; | ||
|
|
||
| // declare module '@mui/material/styles' { |
Contributor
There was a problem hiding this comment.
is there a reason to include this commit with the commented-out block?
| // }; | ||
| // } | ||
| // } | ||
| declare module '@mui/material/styles' { |
Contributor
There was a problem hiding this comment.
I believe this needs to be moved to src/headlamp-plugin.d.ts, it's complaining about this:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal with this is to upgrade headlamp-plugin so we have better type checking and docs for things in the code.
But also to upgrade langchain and others so that building the next thing on top we can have the latest.