Skip to content

Commit a9f3f0a

Browse files
committed
adds server version check to new tests
1 parent 7d9f4fd commit a9f3f0a

10 files changed

+32
-2
lines changed

src/BuildMetadata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class BuildMetadata {
2020
private static readonly MAJOR_VERSION_MULTIPLIER = 10000;
2121
private static readonly MINOR_VERSION_MULTIPLIER = 100;
2222

23-
private static readonly PATTERN = /^([\d]+)\.([\d]+)(?:\.([\d]+))?(-[\w]+)?(-SNAPSHOT)?$/;
23+
private static readonly PATTERN = /^([\d]+)\.([\d]+)(?:\.([\d]+))?(-[\w]+)?(-SNAPSHOT)?(-BETA-.)?$/;
2424

2525
public static calculateVersion(versionString: string): number {
2626
if (versionString == null) {

test/Util.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,13 @@ exports.markEnterprise = function (_this) {
7777
};
7878

7979
exports.markServerVersionAtLeast = function (_this, client, expectedVersion) {
80-
var actNumber = client.getClusterService().getOwnerConnection().getConnectedServerVersion();
80+
if (process.env['SERVER_VERSION']) {
81+
var actNumber = BuildMetadata.calculateVersion(process.env['SERVER_VERSION']);
82+
} else if (client != null) {
83+
var actNumber = client.getClusterService().getOwnerConnection().getConnectedServerVersion();
84+
} else {
85+
return;
86+
}
8187
var expNumber = BuildMetadata.calculateVersion(expectedVersion);
8288
if (actNumber === BuildMetadata.UNKNOWN_VERSION_ID || actNumber < expNumber) {
8389
_this.skip();

test/flakeid/FlakeIdGeneratorOutOfRangeTest.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ describe("FlakeIdGeneratorOutOfRangeTest", function () {
3030
var client;
3131
var flakeIdGenerator;
3232

33+
before(function () {
34+
Util.markServerVersionAtLeast(this, null, '3.10');
35+
});
36+
3337
afterEach(function () {
3438
return flakeIdGenerator.destroy().then(function () {
3539
client.shutdown();

test/flakeid/FlakeIdGeneratorProxyTest.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ describe("FlakeIdGeneratorProxyTest", function () {
5050
});
5151
});
5252

53+
beforeEach(function () {
54+
Util.markServerVersionAtLeast(this, client, '3.10');
55+
});
56+
5357
afterEach(function () {
5458
return flakeIdGenerator.destroy();
5559
});

test/map/MapAggregatorsDoubleTest.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ var Aggregators = require('../../').Aggregators;
2020
var Predicates = require('../../').Predicates;
2121
var _fillMap = require('../Util').fillMap;
2222
var expect = require('chai').expect;
23+
var Util = require('../Util');
2324

2425
describe('MapAggregatorsDoubleTest', function () {
2526
var cluster;
@@ -44,6 +45,7 @@ describe('MapAggregatorsDoubleTest', function () {
4445
});
4546

4647
beforeEach(function () {
48+
Util.markServerVersionAtLeast(this, client, '3.8');
4749
return _fillMap(map, 50, 'key', 0);
4850
});
4951

test/map/MapAggregatorsIntTest.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ var Aggregators = require('../../').Aggregators;
2121
var Predicates = require('../../').Predicates;
2222
var _fillMap = require('../Util').fillMap;
2323
var expect = require('chai').expect;
24+
var Util = require('../Util');
2425

2526
describe('MapAggregatorsIntTest', function () {
2627
var cluster;
@@ -47,6 +48,7 @@ describe('MapAggregatorsIntTest', function () {
4748
});
4849

4950
beforeEach(function () {
51+
Util.markServerVersionAtLeast(this, client, '3.8');
5052
return _fillMap(map, 50, 'key', 0);
5153
});
5254

test/map/MapAggregatorsLongTest.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ var Aggregators = require('../../').Aggregators;
2121
var Predicates = require('../../').Predicates;
2222
var Long = require('long');
2323
var expect = require('chai').expect;
24+
var Util = require('../Util');
2425

2526
describe('MapAggregatorsLongTest', function () {
2627
var cluster;
@@ -48,6 +49,7 @@ describe('MapAggregatorsLongTest', function () {
4849
});
4950

5051
beforeEach(function () {
52+
Util.markServerVersionAtLeast(this, client, '3.8');
5153
var entries = [];
5254
for (var i = 0; i < entryCount; i++) {
5355
entries.push(['key' + i, Long.fromNumber(i)]);

test/pncounter/PNCounterBasicTest.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
var expect = require('chai').expect;
1818
var RC = require('../RC');
1919
var Client = require('../../').Client;
20+
var Util = require('../Util');
2021

2122
describe('PNCounterBasicTest', function () {
2223

@@ -41,6 +42,7 @@ describe('PNCounterBasicTest', function () {
4142
});
4243

4344
beforeEach(function () {
45+
Util.markServerVersionAtLeast(this, client, '3.10');
4446
pncounter = client.getPNCounter('pncounter')
4547
});
4648

test/pncounter/PNCounterConsistencyTest.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ describe('PNCounterConsistencyTest', function () {
3030
var member1;
3131
var client;
3232

33+
before(function () {
34+
Util.markServerVersionAtLeast(this, null, '3.10');
35+
});
36+
3337
beforeEach(function () {
3438
this.timeout(10000);
3539
return RC.createCluster(null, fs.readFileSync(path.resolve(__dirname, 'hazelcast_crdtreplication_delayed.xml'), 'utf8')).then(function (cl) {
@@ -52,6 +56,7 @@ describe('PNCounterConsistencyTest', function () {
5256
});
5357

5458
it('target replica killed, no replica is sufficiently up-to-date, get operation throws ConsistencyLostError', function () {
59+
Util.markServerVersionAtLeast(this, client, '3.10');
5560
var pncounter = client.getPNCounter('pncounter');
5661
return pncounter.getAndAdd(3).then(function () {
5762
var currentReplicaAddress = pncounter.currentTargetReplicaAddress;
@@ -63,6 +68,7 @@ describe('PNCounterConsistencyTest', function () {
6368
});
6469

6570
it('target replica killed, no replica is sufficiently up-to-date, get operation may proceed after calling reset', function () {
71+
Util.markServerVersionAtLeast(this, client, '3.10');
6672
var pncounter = client.getPNCounter('pncounter');
6773
return pncounter.getAndAdd(3).then(function () {
6874
var currentReplicaAddress = pncounter.currentTargetReplicaAddress;

test/pncounter/PNCounterWithLiteMembersTest.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ var Client = require('../..').Client;
2222
var Errors = require('../..').HazelcastErrors;
2323
var fs = require('fs');
2424
var path = require('path');
25+
var Util = require('../Util');
2526

2627
describe('PNCounterWithLiteMembersTest', function () {
2728

@@ -46,6 +47,7 @@ describe('PNCounterWithLiteMembersTest', function () {
4647
});
4748

4849
beforeEach(function () {
50+
Util.markServerVersionAtLeast(this, client, '3.10');
4951
pncounter = client.getPNCounter('pncounter');
5052
});
5153

0 commit comments

Comments
 (0)