Fix for statistics test failure (#438)

* Fix for statistics test failure

StatisticsTest gets client statistics of the first client from cluster. The assumption that the server must have only 1 client should be true in isolation but when there are hanging clients from other tests, these may authenticate to the cluster as well. In that case, server may send the statistics of a wrong client which is null mostly.

Adds logging to partition table request failure
Fixes hanging clients in LoggingTest, FactoriesTest, SemaphoreProxyTest, CustomSerializerTest
Various test refactors

* Refactors StatisticsTest to use specific clientUuids

StatisticsTest is enhanced to request for a specific client's statistcs

Author: mustafaiman

src/HazelcastClient.ts

@@ -373,13 +373,13 @@ export default class HazelcastClient {
      * Shuts down this client instance.
      */
     shutdown(): void {
+        this.lifecycleService.emitLifecycleEvent(LifecycleEvent.shuttingDown);
         if (this.mapRepairingTask !== undefined) {
             this.mapRepairingTask.shutdown();
         }
         this.nearCacheManager.destroyAllNearCaches();
         this.statistics.stop();
         this.partitionService.shutdown();
-        this.lifecycleService.emitLifecycleEvent(LifecycleEvent.shuttingDown);
         this.heartbeat.cancel();
         this.connectionManager.shutdown();
         this.listenerService.shutdown();

src/PartitionService.ts

@@ -71,7 +71,8 @@ export class PartitionService {
                 this.partitionCount = Object.keys(this.partitionMap).length;
             }).catch((e) => {
                 if (this.client.getLifecycleService().isRunning()) {
-                    this.logger.warn('PartitionService', 'Error while fetching cluster partition table!', e);
+                    this.logger.warn('PartitionService', 'Error while fetching cluster partition table from'
+                        + this.client.getClusterService().ownerUuid, e);
                 }
             });
     }

src/invocation/ClusterService.ts

@@ -102,11 +102,11 @@ export class ClusterService {
 
         let providerAddresses: Set<string> = new Set();
         const promises: Array<Promise<void>> = [];
-        this.client.getConnectionManager().addressProviders.forEach(function (addressProvider): void {
+        this.client.getConnectionManager().addressProviders.forEach((addressProvider) => {
             promises.push(addressProvider.loadAddresses().then((res) => {
                 providerAddresses = new Set([...Array.from(providerAddresses), ...res]);
             }).catch((err) => {
-                this.logger.warning('Error from AddressProvider: ' + addressProvider, err);
+                this.logger.warn('Error from AddressProvider: ' + addressProvider, err);
             }));
         });
         return Promise.all(promises).then(() => {

src/statistics/Statistics.ts

@@ -112,8 +112,9 @@ export class Statistics {
 
     sendStats(newStats: string, ownerConnection: ClientConnection): void {
         const request = ClientStatisticsCodec.encodeRequest(newStats);
-
-        this.client.getInvocationService().invokeOnTarget(request, ownerConnection.getAddress()).catch((err) => {
+        this.logger.trace('Statistics', 'Trying to send statistics to ' +
+            this.client.getClusterService().ownerUuid + ' from ' + ownerConnection.getLocalAddress().toString());
+        this.client.getInvocationService().invokeOnConnection(ownerConnection, request).catch((err) => {
             this.logger.trace('Statistics', 'Could not send stats ', err);
         });
     }

test/ClusterServiceTest.js

@@ -61,7 +61,7 @@ describe('ClusterService', function () {
                 expect(client.clusterService.getSize()).to.be.eq(2);
                 done();
             }
-        }
+        };
 
         client.clusterService.addMembershipListener(membershipListener);
 
@@ -78,7 +78,7 @@ describe('ClusterService', function () {
                 expect(client.getClusterService().getSize()).to.be.eq(1);
                 done();
             }
-        }
+        };
 
         client.clusterService.addMembershipListener(membershipListener);
 
@@ -101,7 +101,7 @@ describe('ClusterService', function () {
                 expect(remainingMemberList[1].address.port).to.equal(member3.port);
                 done();
             }
-        }
+        };
 
         client.clusterService.addMembershipListener(membershipListener);
 

test/LoggingTest.js

@@ -134,23 +134,26 @@ describe('Logging Test', function () {
 
     it('default logging, default level', function () {
         var cfg = new Config.ClientConfig();
-        return HazelcastClient.newHazelcastClient(cfg).then(function () {
+        return HazelcastClient.newHazelcastClient(cfg).then(function (cl) {
+            client = cl;
             return sinon.assert.calledWithMatch(console.log, '[DefaultLogger] %s at %s: %s', 'INFO');
         });
     });
 
     it('default logging, error level', function () {
         var cfg = new Config.ClientConfig();
         cfg.properties['hazelcast.logging.level'] = LogLevel.ERROR;
-        return HazelcastClient.newHazelcastClient(cfg).then(function () {
+        return HazelcastClient.newHazelcastClient(cfg).then(function (cl) {
+            client = cl;
             return sinon.assert.notCalled(console.log);
         });
     });
 
     it('default logging, trace level', function () {
         var cfg = new Config.ClientConfig();
         cfg.properties['hazelcast.logging.level'] = LogLevel.TRACE;
-        return HazelcastClient.newHazelcastClient(cfg).then(function () {
+        return HazelcastClient.newHazelcastClient(cfg).then(function (cl) {
+            client = cl;
             return sinon.assert.calledWithMatch(console.log, '[DefaultLogger] %s at %s: %s', 'INFO');
             return sinon.assert.calledWithMatch(console.log, '[DefaultLogger] %s at %s: %s', 'DEBUG');
             return sinon.assert.calledWithMatch(console.log, '[DefaultLogger] %s at %s: %s', 'TRACE');

test/LostConnectionTest.js

@@ -63,7 +63,7 @@ describe('Lost connection', function () {
                     }
                 });
             }
-        }
+        };
 
         client.clusterService.addMembershipListener(membershipListener);
         Controller.startMember(cluster.id).then(function (m) {

test/MembershipListenerTest.js

@@ -58,7 +58,7 @@ describe('MembershipListener', function () {
             memberAdded: function (membershipEvent) {
                 listenerCalledResolver.resolve(membershipEvent);
             }
-        }
+        };
         client.clusterService.addMembershipListener(membershipListener);
 
         Controller.startMember(cluster.id).then(function (res) {
@@ -89,13 +89,13 @@ describe('MembershipListener', function () {
             memberAdded: function (membershipEvent) {
                 listenerCalledResolver.resolve(membershipEvent);
             }
-        }
+        };
 
         var membershipListener2 = {
             memberAdded: function (membershipEvent) {
                 listenedSecondListener = true;
             }
-        }
+        };
         client.clusterService.addMembershipListener(membershipListener);
         client.clusterService.addMembershipListener(membershipListener2);
 
@@ -126,7 +126,7 @@ describe('MembershipListener', function () {
             memberAdded: function (membershipEvent) {
                 counter++;
             }
-        }
+        };
         client.clusterService.addMembershipListener(membershipListener);
         client.clusterService.addMembershipListener(membershipListener);
 
@@ -148,7 +148,7 @@ describe('MembershipListener', function () {
             memberRemoved: function (membershipEvent) {
                 listenerCalledResolver.resolve(membershipEvent);
             }
-        }
+        };
 
         client.clusterService.addMembershipListener(membershipListener);
 
@@ -182,8 +182,7 @@ describe('MembershipListener', function () {
                 }
             },
         };
-        client.clusterService.addMembershipListener(membershipListener)
-
+        client.clusterService.addMembershipListener(membershipListener);
 
         var script = 'function attrs() { ' +
             'return instance_0.getCluster().getLocalMember().setIntAttribute("test", 123); }; result=attrs();';
@@ -199,8 +198,8 @@ describe('MembershipListener', function () {
                     done();
                 }
             }
-        }
-        client.clusterService.addMembershipListener(membershipListener)
+        };
+        client.clusterService.addMembershipListener(membershipListener);
 
         var addScript = 'function attrs() { ' +
             'return instance_0.getCluster().getLocalMember().setIntAttribute("test", 123); }; result=attrs();';

test/declarative_config/ConfigLocationTest.js

@@ -80,7 +80,6 @@ describe('ConfigLocationTest', function () {
         expect(RuntimeUtil.resolvePath('..')).to.equal(process.cwd());
         process.env[ENV_VARIABLE_NAME] = '/anAbsoluteBase/config.json';
         var root = path.parse(process.cwd()).root;
-        console.log(root);
         expect(RuntimeUtil.resolvePath('.')).to.equal(path.join(root, 'anAbsoluteBase'));
         expect(RuntimeUtil.resolvePath('filename')).to.equal(path.join(root, 'anAbsoluteBase', 'filename'));
         expect(RuntimeUtil.resolvePath('..')).to.equal(root);

test/semaphore/SemaphoreProxyTest.js

@@ -53,6 +53,7 @@ describe("Semaphore Proxy", function () {
 
     after(function () {
         client1.shutdown();
+        client2.shutdown();
         return Controller.shutdownCluster(cluster.id);
     });