Use consistent property for Hazelcast version specification (#1275)

When building, we specify the Hazelcast (platform) version via
`config.env`:
https://github.com/hazelcast/hazelcast-cpp-client/blob/a48374e064e87febb3feb274a53170175b80bfdd/.github/config.env#L4

Specifically, in a `HAZELCAST_VERSION` property.

In `start-rc` we do something similar, with a default value if not
provided for local execution:
https://github.com/hazelcast/hazelcast-cpp-client/blob/a48374e064e87febb3feb274a53170175b80bfdd/scripts/start-rc.sh#L37

Note the property there is `HZ_VERSION`.

This means if you try to specify a _different_ Hazelcast version by
changing the config, the `start-rc` script fails as it can't find the
`hazelcast-enterprise-???-tests.jar` file.

Updated to rename the `HAZELCAST_VERSION` property as it [was introduced
more
recently](#1231).

Author: JackPGreen

.github/actions/build-test/unix/action.yml

@@ -37,7 +37,7 @@ runs:
     - name: Download hazelcast-enterprise-tests.jar
       shell: ${{ env.shell }}
       run: |
-        gh api "/repos/hazelcast/private-test-artifacts/contents/certs.jar?ref=data" -H "Accept: application/vnd.github.raw" > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
+        gh api "/repos/hazelcast/private-test-artifacts/contents/certs.jar?ref=data" -H "Accept: application/vnd.github.raw" > hazelcast-enterprise-${{ env.HZ_VERSION }}-tests.jar
       env:
         GH_TOKEN: ${{ inputs.GH_TOKEN }}
 

.github/actions/build-test/windows/action.yml

@@ -57,7 +57,7 @@ runs:
     - name: Download hazelcast-enterprise-tests.jar
       shell: ${{ env.shell }}
       run: |
-        gh api "/repos/hazelcast/private-test-artifacts/contents/certs.jar?ref=data" -H "Accept: application/vnd.github.raw" > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
+        gh api "/repos/hazelcast/private-test-artifacts/contents/certs.jar?ref=data" -H "Accept: application/vnd.github.raw" > hazelcast-enterprise-${{ env.HZ_VERSION }}-tests.jar
       env:
         GH_TOKEN: ${{ inputs.GH_TOKEN }}
 

.github/actions/coverage-report/action.yml

@@ -39,7 +39,7 @@ runs:
     - name: Download hazelcast-enterprise-tests.jar
       shell: ${{ env.shell }}
       run: |
-        gh api "/repos/hazelcast/private-test-artifacts/contents/certs.jar?ref=data" -H "Accept: application/vnd.github.raw" > hazelcast-enterprise-${{ env.HAZELCAST_VERSION }}-tests.jar
+        gh api "/repos/hazelcast/private-test-artifacts/contents/certs.jar?ref=data" -H "Accept: application/vnd.github.raw" > hazelcast-enterprise-${{ env.HZ_VERSION }}-tests.jar
       env:
         GH_TOKEN: ${{ inputs.GH_TOKEN }}
 

.github/config.env

@@ -1,4 +1,4 @@
 JAVA_VERSION=17
 JAVA_DISTRIBUTION=temurin
 MAVEN_VERSION=3.9.9
-HAZELCAST_VERSION=5.4.0
+HZ_VERSION=5.4.0