Skip to content

Commit 96c2bfc

Browse files
Promote params to v1 for google_compute_router resource (#15225) (#10844)
[upstream:e895a76dbcbbbda2a7bf1bc895d4930d1c5d96bc] Signed-off-by: Modular Magician <magic-modules@google.com>
1 parent f80abf2 commit 96c2bfc

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.changelog/15225.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
compute: added `params` field to `google_compute_router` resource (GA)
3+
```

google-beta/services/compute/resource_compute_router_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
//
99
// This code is generated by Magic Modules using the following:
1010
//
11-
// Source file: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.tmpl
11+
// Source file: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/compute/resource_compute_router_test.go
1212
//
1313
// DO NOT EDIT this file directly. Any changes made to this file will be
1414
// overwritten during the next generation cycle.
@@ -226,6 +226,7 @@ func TestAccComputeRouter_addAndUpdateIdentifierRangeBgp(t *testing.T) {
226226
},
227227
})
228228
}
229+
229230
func TestAccComputeRouter_resourceManagerTags(t *testing.T) {
230231
t.Parallel()
231232
org := envvar.GetTestOrgFromEnv(t)
@@ -247,7 +248,7 @@ func TestAccComputeRouter_resourceManagerTags(t *testing.T) {
247248

248249
acctest.VcrTest(t, resource.TestCase{
249250
PreCheck: func() { acctest.AccTestPreCheck(t) },
250-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
251+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
251252
CheckDestroy: testAccCheckComputeRouterDestroyProducer(t),
252253
Steps: []resource.TestStep{
253254
{
@@ -439,23 +440,21 @@ resource "google_compute_router" "foobar" {
439440
}
440441
`, routerName, routerName)
441442
}
443+
442444
func testAccComputeRouter_resourceManagerTags(context map[string]interface{}) string {
443445
return acctest.Nprintf(`
444446
resource "google_compute_network" "foobar" {
445-
provider = google-beta
446447
name = "%{network_name}"
447448
auto_create_subnetworks = false
448449
}
449450
450451
resource "google_compute_subnetwork" "foobar" {
451-
provider = google-beta
452452
name = "%{subnet_name}"
453453
network = google_compute_network.foobar.self_link
454454
ip_cidr_range = "10.0.0.0/16"
455455
}
456456
457457
resource "google_compute_router" "foobar" {
458-
provider = google-beta
459458
name = "%{router_name}"
460459
region = google_compute_subnetwork.foobar.region
461460
network = google_compute_network.foobar.name

website/docs/r/compute_router.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ The following arguments are supported:
123123
Structure is [documented below](#nested_md5_authentication_keys).
124124

125125
* `params` -
126-
(Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html))
126+
(Optional)
127127
Additional params passed with the request, but not persisted as part of resource payload
128128
Structure is [documented below](#nested_params).
129129

0 commit comments

Comments
 (0)