CLEANUP/MINOR: gofumpt: gofumpt the codebase

Author: mjuraga

.aspell.yml

@@ -27,6 +27,7 @@ allowed:
   - cli
   - clickhouse
   - cnt
+  - codebase
   - composable
   - conf
   - config
@@ -68,6 +69,7 @@ allowed:
   - github
   - gitlab
   - godaddy
+  - gofumpt
   - gokc
   - golang
   - golangci

config-parser/tests/configs/parser_test.go

@@ -102,7 +102,7 @@ func TestGeneratedConfig(t *testing.T) {
 	for _, configLine := range configTests {
 		count := strings.Count(result, configLine.Line)
 		if count != configLine.Count {
-			_ = os.WriteFile("/tmp/HAGEN.cfg", []byte(result), 0644)
+			_ = os.WriteFile("/tmp/HAGEN.cfg", []byte(result), 0o644)
 			t.Fatalf("line '%s' found %d times, expected %d times", configLine.Line, count, configLine.Count)
 		}
 	}

runtime/crl_files_test.go

@@ -280,7 +280,7 @@ Status: Used
 			}
 			if !reflect.DeepEqual(got, tt.want) {
 				t.Error("SingleRuntime.ShowCrlFile(): ", cmp.Diff(got, tt.want))
-				//t.Errorf("SingleRuntime.ShowCrlFile() = %v, want %v", got, tt.want)
+				// t.Errorf("SingleRuntime.ShowCrlFile() = %v, want %v", got, tt.want)
 			}
 		})
 	}

runtime/crt_lists.go

@@ -10,10 +10,12 @@ import (
 )
 
 // These type aliases are provided for backward compatibility.
-type CrtListEntry = models.SslCrtListEntry //nolint:gofumpt
-type CrtListEntries = models.SslCrtListEntries
-type CrtList = models.SslCrtList
-type CrtLists = models.SslCrtLists
+type (
+	CrtListEntry   = models.SslCrtListEntry //nolint:gofumpt
+	CrtListEntries = models.SslCrtListEntries
+	CrtList        = models.SslCrtList
+	CrtLists       = models.SslCrtLists
+)
 
 // ShowCrtLists returns CrtList files description from runtime
 func (s *SingleRuntime) ShowCrtLists() (models.SslCrtLists, error) {

test/structured_backend_test.go

@@ -396,7 +396,8 @@ func TestCreateEditDeleteStructuredBackend(t *testing.T) {
 					Enabled: misc.StringP("enabled"),
 					Except:  "127.0.0.1",
 				},
-			}},
+			},
+		},
 		{
 			BackendBase: models.BackendBase{
 				Name: "created",
@@ -464,7 +465,8 @@ func TestCreateEditDeleteStructuredBackend(t *testing.T) {
 					{Cond: misc.StringP("if"), CondTest: misc.StringP("host_www")},
 					{Cond: misc.StringP("unless"), CondTest: misc.StringP("missing_cl")},
 				},
-			}},
+			},
+		},
 	}
 
 	for _, bck := range backends {
@@ -553,7 +555,8 @@ func TestCreateEditDeleteStructuredBackendHTTPConnectionMode(t *testing.T) {
 						},
 					},
 					HTTPConnectionMode: "httpclose",
-				}},
+				},
+			},
 			expectedHTTPConnectionMode: "httpclose",
 		},
 		{
@@ -569,7 +572,8 @@ func TestCreateEditDeleteStructuredBackendHTTPConnectionMode(t *testing.T) {
 						},
 					},
 					HTTPConnectionMode: "http-keep-alive",
-				}},
+				},
+			},
 			expectedHTTPConnectionMode: "http-keep-alive",
 		},
 		{
@@ -585,7 +589,8 @@ func TestCreateEditDeleteStructuredBackendHTTPConnectionMode(t *testing.T) {
 						},
 					},
 					HTTPConnectionMode: "",
-				}},
+				},
+			},
 			expectedHTTPConnectionMode: "",
 		},
 	}

test/structured_global_test.go

@@ -72,5 +72,4 @@ func TestPutStructuredGlobal(t *testing.T) {
 
 	err = clientTest.PushStructuredGlobalConfiguration(g, "", 55)
 	require.Error(t, err, "Should have returned version conflict.")
-
 }

test/structured_log_forward_test.go

@@ -83,7 +83,6 @@ func TestGetStructuredLogForward(t *testing.T) {
 
 	_, _, err = clientTest.GetStructuredLogForward("doesnotexist", "")
 	require.Error(t, err, "should throw error, non existent log forwards section")
-
 }
 
 func TestCreateEditDeleteStructuredLogForward(t *testing.T) {
@@ -154,5 +153,4 @@ func TestCreateEditDeleteStructuredLogForward(t *testing.T) {
 
 	err = clientTest.DeleteLogForward("doesnotexist", "", version)
 	require.Error(t, err, "should throw error, non existent log forward")
-
 }

test/structured_traces_test.go

@@ -68,5 +68,4 @@ func TestPutStructuredTraces(t *testing.T) {
 
 	err = clientTest.PushStructuredTraces(traces, "", 55)
 	require.Error(err, "Should have returned version conflict.")
-
 }

test/traces_test.go

@@ -50,7 +50,6 @@ func checkTraces(t *testing.T, traces *models.Traces) {
 }
 
 func TestCreateEditDeleteTraces(t *testing.T) {
-
 	// We cannot start by creating a new traces section, since there is
 	// already one present in $testConf, and this is a unique section.
 	// So let's delete first.