Skip to content

Commit aa18a1a

Browse files
committed
TEST/MINOR: sort acme vars when serializing
This fixes some tests flakiness
1 parent e619b34 commit aa18a1a

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

configuration/acme_provider_test.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,28 +24,22 @@ import (
2424
func Test_serializeAcmeVars(t *testing.T) {
2525
tests := []struct {
2626
vars map[string]string
27-
want []string
27+
want string
2828
wantErr bool
2929
}{
3030
{
3131
vars: map[string]string{"foo": "bar", "ApiKey": "FEFF,==\""},
32-
want: []string{`"foo=bar,ApiKey=FEFF\,==\""`, `"ApiKey=FEFF\,==\",foo=bar"`},
32+
want: `"ApiKey=FEFF\,==\",foo=bar"`,
3333
wantErr: false,
3434
},
3535
}
3636
for _, tt := range tests {
37-
t.Run(tt.want[0], func(t *testing.T) {
37+
t.Run(tt.want, func(t *testing.T) {
3838
got, err := serializeAcmeVars(tt.vars)
3939
if tt.wantErr != (err != nil) {
4040
t.Errorf("serializeAcmeVars() got error '%v', wantErr=%v", err, tt.wantErr)
4141
}
42-
ok := false
43-
for _, wanted := range tt.want {
44-
if !ok {
45-
ok = (got == wanted)
46-
}
47-
}
48-
if !ok {
42+
if got != tt.want {
4943
t.Errorf("serializeAcmeVars() = %v, want %v", got, tt.want)
5044
}
5145
})

0 commit comments

Comments
 (0)