BUG/MEDIUM: default time suffix for stats refresh delay is seconds

hdurand0710 · Gopher Bot · commit 4a278bca3c9a · 2025-11-28T16:04:51.000Z
It was milliseconds which should be seconds.
diff --git a/configuration/configuration.go b/configuration/configuration.go
@@ -1084,7 +1084,7 @@ func (s *SectionParser) statsOptions() interface{} { //nolint:gocognit
 			opt.StatsMaxconn = mc.Value
 		case *stats.Refresh:
 			if v.Delay != "" {
-				opt.StatsRefreshDelay = misc.ParseTimeout(v.Delay)
+				opt.StatsRefreshDelay = misc.ParseTimeoutDefaultSeconds(v.Delay)
 			}
 		case *stats.ShowNode:
 			opt.StatsShowNodeName = misc.StringP(v.Name)
@@ -2574,7 +2574,7 @@ func (s *SectionObject) statsOptions(field reflect.Value) error {
 	}
 	if opt.StatsRefreshDelay != nil {
 		s := &stats.Refresh{
-			Delay: strconv.FormatInt(*opt.StatsRefreshDelay, 10),
+			Delay: misc.SerializeTime(*opt.StatsRefreshDelay, s.Options.PreferredTimeSuffix),
 		}
 		ss = append(ss, s)
 	}
diff --git a/test/configuration_test.go b/test/configuration_test.go
@@ -679,6 +679,7 @@ frontend test
   stats auth admin2:AdMiN1234
   stats show-modules
   stats realm HAProxy\\ Statistics
+  stats refresh 10
   email-alert from srv01@example.com
   email-alert to problems@example.com
   email-alert level warning
diff --git a/test/expected/structured.json b/test/expected/structured.json
@@ -1603,7 +1603,8 @@
                 "stats_realm": true,
                 "stats_realm_realm": "HAProxy\\\\ Statistics",
                 "stats_show_modules": true,
-                "stats_show_node_name": null
+                "stats_show_node_name": null,
+                "stats_refresh_delay": 10000
             },
             "tarpit_timeout": 2000,
             "tcp_smart_accept": "enabled",

Original file line number	Diff line number	Diff line change
`@@ -1084,7 +1084,7 @@ func (s *SectionParser) statsOptions() interface{} { //nolint:gocognit`
`1084`	`1084`	`opt.StatsMaxconn = mc.Value`
`1085`	`1085`	`case *stats.Refresh:`
`1086`	`1086`	`if v.Delay != "" {`
`1087`		`- opt.StatsRefreshDelay = misc.ParseTimeout(v.Delay)`
	`1087`	`+ opt.StatsRefreshDelay = misc.ParseTimeoutDefaultSeconds(v.Delay)`
`1088`	`1088`	`}`
`1089`	`1089`	`case *stats.ShowNode:`
`1090`	`1090`	`opt.StatsShowNodeName = misc.StringP(v.Name)`
`@@ -2574,7 +2574,7 @@ func (s *SectionObject) statsOptions(field reflect.Value) error {`
`2574`	`2574`	`}`
`2575`	`2575`	`if opt.StatsRefreshDelay != nil {`
`2576`	`2576`	`s := &stats.Refresh{`
`2577`		`- Delay: strconv.FormatInt(*opt.StatsRefreshDelay, 10),`
	`2577`	`+ Delay: misc.SerializeTime(*opt.StatsRefreshDelay, s.Options.PreferredTimeSuffix),`
`2578`	`2578`	`}`
`2579`	`2579`	`ss = append(ss, s)`
`2580`	`2580`	`}`