Merge pull request #217 from poor-circle/main

ctre::split a string ends with delimiter may cause undefined behavior, can we use std::to_address to fix it?

Author: hanickadot

include/ctre/return_type.hpp

@@ -9,6 +9,7 @@
 #include <string>
 #include <iterator>
 #include <iosfwd>
+#include <memory>
 #if __has_include(<charconv>)
 #include <charconv>
 #endif
@@ -71,11 +72,19 @@ template <size_t Id, typename Name = void> struct captured_content {
 			if constexpr (std::is_same_v<Iterator, utf8_iterator>) {
 				return _begin.ptr;
 			} else {
+				#if __cpp_lib_to_address >= 201711L
+				return std::to_address(_begin);
+				#else
 				return &*_begin;
+				#endif
 			}
 			#else
+			#if __cpp_lib_to_address >= 201711L
+			return std::to_address(_begin);
+			#else
 			return &*_begin;
 			#endif
+			#endif
 		}
 
 		constexpr CTRE_FORCE_INLINE const auto * data() const noexcept {

single-header/ctre-unicode.hpp

@@ -240,6 +240,7 @@ Software.
 #include <cstddef>
 #include <string_view>
 #include <cstdint>
+#include <memory>
 
 namespace ctll {
 
@@ -2978,11 +2979,19 @@ template <size_t Id, typename Name = void> struct captured_content {
 			if constexpr (std::is_same_v<Iterator, utf8_iterator>) {
 				return _begin.ptr;
 			} else {
+				#if __cpp_lib_to_address >= 201711L
+				return std::to_address(_begin);
+				#else
 				return &*_begin;
+				#endif
 			}
 			#else
+			#if __cpp_lib_to_address >= 201711L
+			return std::to_address(_begin);
+			#else
 			return &*_begin;
 			#endif
+			#endif
 		}
 
 		constexpr CTRE_FORCE_INLINE const auto * data() const noexcept {

single-header/ctre.hpp

@@ -237,6 +237,7 @@ Software.
 #include <cstddef>
 #include <string_view>
 #include <cstdint>
+#include <memory>
 
 namespace ctll {
 
@@ -2975,11 +2976,19 @@ template <size_t Id, typename Name = void> struct captured_content {
 			if constexpr (std::is_same_v<Iterator, utf8_iterator>) {
 				return _begin.ptr;
 			} else {
+				#if __cpp_lib_to_address >= 201711L
+				return std::to_address(_begin);
+				#else
 				return &*_begin;
+				#endif
 			}
 			#else
+			#if __cpp_lib_to_address >= 201711L
+			return std::to_address(_begin);
+			#else
 			return &*_begin;
 			#endif
+			#endif
 		}
 
 		constexpr CTRE_FORCE_INLINE const auto * data() const noexcept {