feat(Device): Implement store status handler #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekurtovic
force-pushed
the
feat-store-status
branch
from
ae45254 to
12e09b5
Compare
Owner
|
Nice, I've been meaning to do this for a long time, just never became a priority :) Thanks! |
thekurtovic
force-pushed
the
feat-store-status
branch
2 times, most recently
from
ca991f6 to
11d8616
Compare
Collaborator
Author
|
Updated documentation to clarify return codes. |
Owner
|
The default callback should still call |
thekurtovic
force-pushed
the
feat-store-status
branch
from
11d8616 to
e45c326
Compare
thekurtovic
force-pushed
the
feat-store-status
branch
from
e45c326 to
6549f36
Compare
Contributor
|
Thanks for implementing this, definitely helpful :) |
12 tasks
finger563
added a commit
to esp-cpp/esp-nimble-cpp
that referenced
this pull request
Feb 10, 2025
* Add missing definition for default device callbacks (which prevents calling the `setDeviceCallbacks` method) * Ensure `m_pDeviceCallbacks` inital value is set to `&defaultDeviceCallbacks` to prevent crash when pairing table is full After h2zero#295 any time the pairing table fills up, the device will crash on the next pairing attempt.
h2zero
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Add missing definition for default device callbacks (which prevents calling the `setDeviceCallbacks` method) * Ensure `m_pDeviceCallbacks` inital value is set to `&defaultDeviceCallbacks` to prevent crash when pairing table is full After #295 any time the pairing table fills up, the device will crash on the next pairing attempt.
h2zero
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Add missing definition for default device callbacks (which prevents calling the `setDeviceCallbacks` method) * Ensure `m_pDeviceCallbacks` inital value is set to `&defaultDeviceCallbacks` to prevent crash when pairing table is full After #295 any time the pairing table fills up, the device will crash on the next pairing attempt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.