Refactor client connection establishment and client deletion. #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
client-connection-improvements
branch
2 times, most recently
from
5b23b1c to
7a98fa8
Compare
h2zero
force-pushed
the
client-connection-improvements
branch
2 times, most recently
from
fe6bc93 to
bc76384
Compare
thekurtovic
reviewed
Nov 16, 2024
h2zero
force-pushed
the
client-connection-improvements
branch
from
bc76384 to
86d5ebe
Compare
h2zero
force-pushed
the
client-connection-improvements
branch
4 times, most recently
from
32a8ef8 to
3733eeb
Compare
* Removes the connection established flag as it should not be necessary. * Deleting the client instance from the `onDisconnect` callback is now supported. * `NimBLEDevice::deleteClient` no longer blocks tasks * Adds a new `Config` struct to `NimBLEClient` to efficiently set single bit config settings. * Adds `NimBLEClient::setSelfDelete` that takes the bool parameters `deleteOnDisconnect` and `deleteOnConnectFail` This will configure the client to delete itself when disconnected or the connection attempt fails. * Adds `NimBLEClient::setConfig` and `NimBLEClient::getConfig` which takes or returns a `NimBLEClient::Config` object respectively. * Reword `BLE_HS_EAPP` error string to be more accurate.
h2zero
force-pushed
the
client-connection-improvements
branch
from
3733eeb to
97d450e
Compare
Replaces `NimBLEDevice::setConnectionInProgress` and `NimBLEDevice::isConnectionInProgress()` with lower level checks to avoid potential incorrect state reporting. `NimBLEClient::connect` will instead call `NimBLEScan::stop` if it stopped the scan to release any resources waiting, the call the callback if set.
h2zero
force-pushed
the
client-connection-improvements
branch
from
97d450e to
78d2303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the connection established flag as it should not be necessary.
Deleting the client instance from the
onDisconnectcallback is now supported.NimBLEDevice::deleteClientno longer blocks tasksAdds a new
Configstruct toNimBLEClientto efficiently set single bit config settings.Adds
NimBLEClient::setSelfDeletethat takes the bool parametersdeleteOnDisconnectanddeleteOnConnectFailThis will configure the client to delete itself when disconnected or the connection attempt fails.
Adds
NimBLEClient::setConfigandNimBLEClient::getConfigwhich takes or returns aNimBLEClient::Configobject respectively.Reword
BLE_HS_EAPPerror string to be more accurate.