Skip to content

Commit 917412a

Browse files
authored
Merge pull request #12 from guojiex/search_cache
Simplified code.
2 parents d6cdb86 + d01a2fb commit 917412a

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

lib/CustomImageSearchPage.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ class _CustomImageSearchDemoState extends State<CustomImageSearchDemo> {
1616
// new CustomSearchSearchDelegate.imageSearch(
1717
// dataSource: CustomSearchDataSource(
1818
// cx: '',
19-
// apiKey: ''),
20-
// autoCompleteDataSource: CommonEnglishWordAutoCompleteDataSource());
19+
// apiKey: ''));
2120
final GlobalKey<ScaffoldState> _scaffoldKey = new GlobalKey<ScaffoldState>();
2221

2322
void triggerShowSearch() async {

lib/CustomWebSearchPage.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ class _CustomWebSearchDemoState extends State<CustomWebSearchDemo> {
1212
.fakeStaticSource();
1313

1414
// final CustomSearchSearchDelegate _delegate = new CustomSearchSearchDelegate(
15-
// dataSource: CustomSearchDataSource(cx: '', apiKey: ''),
16-
// autoCompleteDataSource: CommonEnglishWordAutoCompleteDataSource());
15+
// dataSource: CustomSearchDataSource(
16+
// cx: '',
17+
// apiKey: ''));
1718
final GlobalKey<ScaffoldState> _scaffoldKey = new GlobalKey<ScaffoldState>();
1819

1920
void triggerShowSearch() async {

lib/search_data_source.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import 'package:english_words/english_words.dart';
1010

1111
/// A wrapper class for [customsearch.Result].
1212
/// [SearchResult] will use the landing page link to measure if two results are
13-
/// the same. This is useful for deduplicate image search result.
13+
/// the same. This is useful for deduplicating image search result.
1414
class SearchResult {
1515
final customsearch.Result result;
1616

@@ -69,9 +69,8 @@ class SearchResults {
6969
SearchResults.empty();
7070

7171
SearchResults(customsearch.Search search) {
72-
search.items.forEach(
73-
(item) =>
74-
searchResults.add(SearchResult.escapeLineBreakInSnippet(item)));
72+
search.items.forEach((item) =>
73+
searchResults.add(SearchResult.escapeLineBreakInSnippet(item)));
7574
}
7675
}
7776

@@ -119,7 +118,6 @@ class FakeSearchDataSource implements SearchDataSource {
119118
if (searchResponses[query].searchType != searchType) {
120119
return SearchResults.empty();
121120
}
122-
var results = List<SearchResult>();
123121
Map searchMap = jsonDecode(searchResponses[query].searchResponseJsonString);
124122
customsearch.Search search = customsearch.Search.fromJson(searchMap);
125123
return SearchResults(search);
@@ -143,7 +141,6 @@ class CustomSearchDataSource implements SearchDataSource {
143141
if (query.isEmpty) {
144142
return SearchResults.empty();
145143
}
146-
var results = List<SearchResult>();
147144
customsearch.Search search =
148145
await this.api.cse.list(query, cx: this.cx, searchType: searchType);
149146
searchCount += 1;

lib/search_result_page.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ enum WebSearchLayout { simple, CSE }
168168

169169
class CustomSearchSearchDelegate extends SearchDelegate<SearchResult> {
170170
SearchDataSource dataSource;
171-
AutoCompleteDataSource autoCompleteDataSource;
171+
AutoCompleteDataSource autoCompleteDataSource = CommonEnglishWordAutoCompleteDataSource();
172172
SearchType searchType;
173173

174174
CustomSearchSearchDelegate(
@@ -183,7 +183,6 @@ class CustomSearchSearchDelegate extends SearchDelegate<SearchResult> {
183183

184184
CustomSearchSearchDelegate.fakeStaticSource() {
185185
this.dataSource = FakeSearchDataSource();
186-
this.autoCompleteDataSource = CommonEnglishWordAutoCompleteDataSource();
187186
this.searchType = SearchType.web;
188187
}
189188
@override
@@ -251,11 +250,8 @@ class CustomSearchSearchDelegate extends SearchDelegate<SearchResult> {
251250
);
252251
}
253252

254-
int buildResultCount = 0;
255253
@override
256254
Widget buildResults(BuildContext context) {
257-
buildResultCount += 1;
258-
print(buildResultCount);
259255
return FutureBuilder<SearchResults>(
260256
future: dataSource.search(query,
261257
searchType: this.searchType == SearchType.web ? null : 'image'),

0 commit comments

Comments
 (0)