Add JuliaFormatter (jump-dev#1289)

* Add CI check

* Format codebase

Author: odow

.github/workflows/format_check.yml

@@ -0,0 +1,31 @@
+name: format-check
+on:
+  push:
+    branches:
+      - master
+      - release-*
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: '1'
+      - uses: actions/checkout@v1
+      - name: Format check
+        shell: julia --color=yes {0}
+        run: |
+          using Pkg
+          Pkg.add(PackageSpec(name="JuliaFormatter", version="0.13.2"))
+          using JuliaFormatter
+          format("src", verbose=true)
+          format("test", verbose=true)
+          out = String(read(Cmd(`git diff`)))
+          if isempty(out)
+              exit(0)
+          end
+          @error "Some files have not been formatted !!!"
+          write(stdout, out)
+          exit(1)

src/Benchmarks/Benchmarks.jl

@@ -230,8 +230,8 @@ end
     MOI.add_constraints(
         model,
         [
-            MOI.ScalarAffineFunction([MOI.ScalarAffineTerm(1.0, xi)], 0.0)
-            for xi in x
+            MOI.ScalarAffineFunction([MOI.ScalarAffineTerm(1.0, xi)], 0.0) for
+            xi in x
         ],
         MOI.LessThan.(1:1.0:10_000),
     )

src/Bridges/Constraint/function_conversion.jl

@@ -15,7 +15,11 @@ function MOI.get(
     if invariant_under_function_conversion(attr)
         return MOI.get(model, attr, bridge.constraint)
     else
-        throw(ArgumentError("Bridge of type `$(typeof(bridge))` does not support accessing the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`."))
+        throw(
+            ArgumentError(
+                "Bridge of type `$(typeof(bridge))` does not support accessing the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
+            ),
+        )
     end
 end
 
@@ -36,7 +40,11 @@ function MOI.set(
     if invariant_under_function_conversion(attr)
         return MOI.set(model, attr, bridge.constraint, value)
     else
-        throw(ArgumentError("Bridge of type `$(typeof(bridge))` does not support setting the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`."))
+        throw(
+            ArgumentError(
+                "Bridge of type `$(typeof(bridge))` does not support setting the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
+            ),
+        )
     end
 end
 

src/Bridges/Constraint/geomean_to_relentr.jl

@@ -23,10 +23,12 @@ function bridge_constraint(
 ) where {T,F,G,H}
     f_scalars = MOIU.eachscalar(f)
     (y, nn_index) = MOI.add_constrained_variables(model, MOI.Nonnegatives(1))
-    w_func = MOIU.vectorize(fill(
-        MOIU.operate(+, T, f_scalars[1], MOI.SingleVariable(y[1])),
-        MOI.dimension(s) - 1,
-    ))
+    w_func = MOIU.vectorize(
+        fill(
+            MOIU.operate(+, T, f_scalars[1], MOI.SingleVariable(y[1])),
+            MOI.dimension(s) - 1,
+        ),
+    )
     relentr_func = MOIU.operate(
         vcat,
         T,
@@ -117,11 +119,9 @@ function MOI.get(
     ::MOI.ConstraintFunction,
     bridge::GeoMeantoRelEntrBridge{T,F,G,H},
 ) where {T,F,G,H}
-    relentr_func = MOIU.eachscalar(MOI.get(
-        model,
-        MOI.ConstraintFunction(),
-        bridge.relentr_index,
-    ))
+    relentr_func = MOIU.eachscalar(
+        MOI.get(model, MOI.ConstraintFunction(), bridge.relentr_index),
+    )
     d = div(length(relentr_func) - 1, 2)
     u_func = MOIU.remove_variable(
         MOIU.operate(-, T, relentr_func[end], MOI.SingleVariable(bridge.y)),
@@ -137,11 +137,9 @@ function MOI.get(
 )
     return MOI.GeometricMeanCone(
         1 + div(
-            MOI.dimension(MOI.get(
-                model,
-                MOI.ConstraintSet(),
-                bridge.relentr_index,
-            )) - 1,
+            MOI.dimension(
+                MOI.get(model, MOI.ConstraintSet(), bridge.relentr_index),
+            ) - 1,
             2,
         ),
     )

src/Bridges/Constraint/indicator_sos.jl

@@ -78,11 +78,9 @@ function MOI.get(
     attr::MOI.ConstraintSet,
     b::IndicatorSOS1Bridge,
 )
-    return MOI.IndicatorSet{MOI.ACTIVATE_ON_ONE}(MOI.get(
-        model,
-        attr,
-        b.linear_constraint_index,
-    ),)
+    return MOI.IndicatorSet{MOI.ACTIVATE_ON_ONE}(
+        MOI.get(model, attr, b.linear_constraint_index),
+    )
 end
 
 function MOI.get(

src/Bridges/Constraint/map.jl

@@ -263,7 +263,9 @@ function add_key_for_bridge(
     set::MOI.AbstractScalarSet,
 )
     map.single_variable_constraints[(func.variable.value, typeof(set))] = bridge
-    return MOI.ConstraintIndex{MOI.SingleVariable,typeof(set)}(func.variable.value)
+    return MOI.ConstraintIndex{MOI.SingleVariable,typeof(set)}(
+        func.variable.value,
+    )
 end
 
 """

src/Bridges/Constraint/norm_spec_nuc_to_psd.jl

@@ -89,16 +89,14 @@ function MOI.get(
     ::MOI.ConstraintFunction,
     bridge::NormSpectralBridge{T,F,G},
 ) where {T,F,G}
-    psd_func = MOIU.eachscalar(MOI.get(
-        model,
-        MOI.ConstraintFunction(),
-        bridge.psd_index,
-    ))
+    psd_func = MOIU.eachscalar(
+        MOI.get(model, MOI.ConstraintFunction(), bridge.psd_index),
+    )
     t = psd_func[1]
     side_dim = bridge.row_dim + bridge.column_dim
     X = psd_func[[
-        trimap(i, j) for j in 1:bridge.column_dim
-        for i in (bridge.column_dim+1):side_dim
+        trimap(i, j) for j in 1:bridge.column_dim for
+        i in (bridge.column_dim+1):side_dim
     ]]
     return MOIU.convert_approx(G, MOIU.operate(vcat, T, t, X))
 end
@@ -125,8 +123,8 @@ function MOI.get(
     t = primal[1]
     side_dim = bridge.row_dim + bridge.column_dim
     X = primal[[
-        trimap(i, j) for j in 1:bridge.column_dim
-        for i in (bridge.column_dim+1):side_dim
+        trimap(i, j) for j in 1:bridge.column_dim for
+        i in (bridge.column_dim+1):side_dim
     ]]
     return vcat(t, X)
 end
@@ -314,11 +312,9 @@ function MOI.get(
     bridge::NormNuclearBridge{T,F,G,H},
 ) where {T,F,G,H}
     ge_func = MOI.get(model, MOI.ConstraintFunction(), bridge.ge_index)
-    psd_func = MOIU.eachscalar(MOI.get(
-        model,
-        MOI.ConstraintFunction(),
-        bridge.psd_index,
-    ))
+    psd_func = MOIU.eachscalar(
+        MOI.get(model, MOI.ConstraintFunction(), bridge.psd_index),
+    )
     column_dim = bridge.column_dim
     side_dim = bridge.row_dim + column_dim
     t = MOIU.operate(
@@ -334,8 +330,8 @@ function MOI.get(
     )
     t = MOIU.remove_variable(MOIU.remove_variable(t, bridge.U), bridge.V)
     X = psd_func[[
-        trimap(i, j) for j in 1:bridge.column_dim
-        for i in (bridge.column_dim+1):side_dim
+        trimap(i, j) for j in 1:bridge.column_dim for
+        i in (bridge.column_dim+1):side_dim
     ]]
     return MOIU.convert_approx(H, MOIU.operate(vcat, T, t, X))
 end
@@ -363,8 +359,8 @@ function MOI.get(
     side_dim = bridge.row_dim + bridge.column_dim
     t = ge_primal + sum(psd_primal[trimap(i, i)] for i in 1:side_dim) / 2
     X = psd_primal[[
-        trimap(i, j) for j in 1:bridge.column_dim
-        for i in (bridge.column_dim+1):side_dim
+        trimap(i, j) for j in 1:bridge.column_dim for
+        i in (bridge.column_dim+1):side_dim
     ]]
     return vcat(t, X)
 end
@@ -380,8 +376,8 @@ function MOI.get(
     side_dim = bridge.row_dim + bridge.column_dim
     X =
         2 * psd_dual[[
-            trimap(i, j) for j in 1:bridge.column_dim
-            for i in (bridge.column_dim+1):side_dim
+            trimap(i, j) for j in 1:bridge.column_dim for
+            i in (bridge.column_dim+1):side_dim
         ]]
     return vcat(t, X)
 end

src/Bridges/Constraint/relentr_to_exp.jl

@@ -39,8 +39,8 @@ function bridge_constraint(
         ) for i in 1:v_dim
     ]
     exp_indices = [
-        MOI.add_constraint(model, exp_func_i, MOI.ExponentialCone())
-        for exp_func_i in exp_funcs
+        MOI.add_constraint(model, exp_func_i, MOI.ExponentialCone()) for
+        exp_func_i in exp_funcs
     ]
     return RelativeEntropyBridge{T,F,G,H}(y, ge_index, exp_indices)
 end
@@ -131,11 +131,9 @@ function MOI.get(
     )
     w_start = 1 + length(bridge.y)
     for i in eachindex(bridge.y)
-        exp_func_i = MOIU.eachscalar(MOI.get(
-            model,
-            MOI.ConstraintFunction(),
-            bridge.exp_indices[i],
-        ))
+        exp_func_i = MOIU.eachscalar(
+            MOI.get(model, MOI.ConstraintFunction(), bridge.exp_indices[i]),
+        )
         MOIU.operate_output_index!(-, T, 1, func, exp_func_i[1])
         MOIU.operate_output_index!(+, T, 1 + i, func, exp_func_i[3])
         MOIU.operate_output_index!(+, T, w_start + i, func, exp_func_i[2])

src/Bridges/Constraint/vectorize.jl

@@ -24,13 +24,15 @@ function bridge_constraint(
 ) where {T,F,S,G}
     scalar_const = MOI.constant(scalar_f, T)
     if !iszero(scalar_const)
-        throw(MOI.ScalarFunctionConstantNotZero{
-            typeof(scalar_const),
-            G,
-            typeof(set),
-        }(
-            scalar_const,
-        ))
+        throw(
+            MOI.ScalarFunctionConstantNotZero{
+                typeof(scalar_const),
+                G,
+                typeof(set),
+            }(
+                scalar_const,
+            ),
+        )
     end
     vector_f = convert(F, scalar_f)
     set_const = MOI.constant(set)

src/Bridges/Objective/bridge.jl

@@ -22,7 +22,9 @@ function bridge_objective(
     ::MOI.ModelLike,
     func::MOI.AbstractScalarFunction,
 )
-    return throw(MOI.UnsupportedAttribute(MOI.ObjectiveFunction{typeof(func)}()))
+    return throw(
+        MOI.UnsupportedAttribute(MOI.ObjectiveFunction{typeof(func)}()),
+    )
 end
 
 """
@@ -40,12 +42,14 @@ function MOI.set(
     bridge::AbstractBridge,
     ::MOI.OptimizationSense,
 )
-    return throw(ArgumentError(
-        "Objective bridge of type `$(typeof(bridge))` does not support" *
-        " modifying the objective sense. As a workaround, set the sense to" *
-        " `MOI.FEASIBILITY_SENSE` to clear the objective function and" *
-        " bridges.",
-    ))
+    return throw(
+        ArgumentError(
+            "Objective bridge of type `$(typeof(bridge))` does not support" *
+            " modifying the objective sense. As a workaround, set the sense to" *
+            " `MOI.FEASIBILITY_SENSE` to clear the objective function and" *
+            " bridges.",
+        ),
+    )
 end
 
 """
@@ -60,10 +64,12 @@ function MOI.get(
     ::MOI.ObjectiveFunction,
     bridge::AbstractBridge,
 )
-    return throw(ArgumentError(
-        "ObjectiveFunction bridge of type `$(typeof(bridge))` does not" *
-        " support getting the objective function.",
-    ))
+    return throw(
+        ArgumentError(
+            "ObjectiveFunction bridge of type `$(typeof(bridge))` does not" *
+            " support getting the objective function.",
+        ),
+    )
 end
 
 """
@@ -72,7 +78,11 @@ end
 Delete any variable or constraint added by `bridge`.
 """
 function MOI.delete(::MOI.ModelLike, bridge::AbstractBridge)
-    return throw(ArgumentError("`MOI.delete` not implemented for `ObjectiveFunction` bridges of type `$(typeof(bridge))`"))
+    return throw(
+        ArgumentError(
+            "`MOI.delete` not implemented for `ObjectiveFunction` bridges of type `$(typeof(bridge))`",
+        ),
+    )
 end
 
 """